Last modified: 2014-03-11 21:27:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64436, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 62436 - SkinTemplate template key 'mobileview' value is not initialized for desktop versions of special pages.
SkinTemplate template key 'mobileview' value is not initialized for desktop v...
Status: RESOLVED DUPLICATE of bug 56139
Product: MobileFrontend
Classification: Unclassified
beta (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-08 15:47 UTC by Dmitriy Sintsov
Modified: 2014-03-11 21:27 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Dmitriy Sintsov 2014-03-08 15:47:36 UTC
I developed custom Vector-derived skin and made few tweaks to Minerva mobile skin. In Vector-derived skin I use $this->html('mobileview') in skin footer. It properly generates &mobileaction=toggle_view_mobile for "ordinary" pages but is not initialized for special pages. The cause is in MobileFrontendHooks::onSkinTemplateOutputPageBeforeExec hook, which skips generation of template variable for special pages:

if ( !$isSpecial && !$context->isBlacklistedPage() ) {
...
}

Is it impossible to switch special pages to Minerva skin or is that a bug? If that's impossible I'd tell the customer that the mobile switch link will be unavailable at special pages.
Comment 1 Bingle 2014-03-08 15:50:09 UTC
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1755
Comment 2 Dmitriy Sintsov 2014-03-08 15:54:37 UTC
I'd imagine that some special pages might be confused by &mobileaction=toggle_view_mobile parameter? In such case there should be a switch via dedicated specal page (something like Special:MobileFrontendSwitch) then redirecting to target special page.
Comment 3 Jon 2014-03-08 16:56:20 UTC
Bug 58566 should fix this... are you running latest master or is the issue still present with the fix for that bug?
Comment 4 Dmitriy Sintsov 2014-03-08 20:30:54 UTC
Updated to latest master and yes not 'mobileview' value is available when running special pages, however _mobile_ versions of special pages do not show &mobileaction=toggle_view_desktop. Mobile versions of "ordinary" pages do have such link in their footer.

Is that normal? I am too tired to investigate the reason.
Comment 5 Dmitriy Sintsov 2014-03-08 20:31:27 UTC
and yes not 'mobileview' == and yes NOW 'mobileview' a typo. Sorry.
Comment 6 Jon 2014-03-11 21:27:18 UTC
Yes, this is currently the case. We are trying to rectify this. If you append mobileaction=beta to the mobile pages you will see the new design we are working on which surfaces these on all pages.
You can follow progress on bug 56139
Thanks for giving us a much needed poke.

*** This bug has been marked as a duplicate of bug 56139 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links