Last modified: 2014-03-17 17:29:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64460, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 62460 - Images get squashed
Images get squashed
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-09 20:43 UTC by Jon
Modified: 2014-03-17 17:29 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
yikes (501.71 KB, image/png)
2014-03-09 20:44 UTC, Jon
Details

Description Jon 2014-03-09 20:43:11 UTC
https://m.mediawiki.org/wiki/Z%C3%BCrich_Hackathon_2014/Geo_Namespace

A max width applies to this image but no height auto so the resulting image gets squashed.
Comment 1 Jon 2014-03-09 20:44:06 UTC
Created attachment 14778 [details]
yikes
Comment 2 Bingle 2014-03-09 20:45:12 UTC
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1756
Comment 3 Jon 2014-03-12 23:27:41 UTC
So the reason this was removed is it conflicts with .ve-ce-protectedNode-shield whis is an image and needs to be able to set its height...
Comment 4 Gerrit Notification Bot 2014-03-12 23:48:43 UTC
Change 118401 had a related patch set uploaded by Jdlrobson:
Don't squash images

https://gerrit.wikimedia.org/r/118401
Comment 5 Gerrit Notification Bot 2014-03-13 21:11:37 UTC
Change 118401 merged by jenkins-bot:
Don't squash images

https://gerrit.wikimedia.org/r/118401
Comment 6 se4598 2014-03-16 14:33:05 UTC
At dewiki we have similiar report for https://de.m.wikipedia.org/wiki/Vorlage:QS-Chemie
with this user-provided image: https://commons.wikimedia.org/wiki/File:Darstellungsfehler.png

I could reproduced myself only with chrome, but with above fix from Jdlrobson applied via Developer Tools the image only shrinks normally but to a so tiny size you can't see it anymore. Firefox displayed the image normal in mobile view.

It only displays normal for me if I disable the "max-width: 100% !important;"-Rule
Comment 7 Jon 2014-03-17 17:29:28 UTC
Yeh, although this patch unsquishes the image, the shrinkage is unrelated to this patch and is confusingly due to the fact that the table cell that contains the image has no declared width. Tables are pretty problematic on mobile (see bug 36936).

If you can I'd recommend moving away from using a table for this template. You can instead use a background image on a DIV like so:
<div style="
    padding-left: 52px;
    background-image: url(//upload.wikimedia.org/wikipedia/commons/thumb/4/42/QS-Chemie-Logo.svg/50px-QS-Chemie-Logo.svg.png);
    background-repeat: no-repeat;
"></div>
Otherwise you can declare a width on the TD element to override the shrinkage.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links