Last modified: 2014-03-20 22:50:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64575, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 62575 - VisualEditor: Beat the reference toolbar button in the reference dialog back down into its grave
VisualEditor: Beat the reference toolbar button in the reference dialog back ...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2014-03-20
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-12 19:42 UTC by Rummana Yasmeen
Modified: 2014-03-20 22:50 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot (40.37 KB, image/png)
2014-03-12 19:42 UTC, Rummana Yasmeen
Details
Wikitext in the reflist (325.88 KB, image/png)
2014-03-12 19:43 UTC, Rummana Yasmeen
Details

Description Rummana Yasmeen 2014-03-12 19:42:52 UTC
Created attachment 14793 [details]
Screenshot

Steps to reproduce:

1.Open a page in VE
2.Insert a reference
3.Open the reference dialog 
4.Insert another reference inside it
5.Save the page

Observed Result:
In read mode :Cite error: Closing </ref> missing for <ref> tag appears
Inside VE: for the reference that is inside another reference, the wikitext appears in the reflist section

See the screenshots attached


Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser: Chrome Version 26.0.1410.65
OS: MAC OS X 10. 8. 5
Comment 1 Rummana Yasmeen 2014-03-12 19:43:31 UTC
Created attachment 14794 [details]
Wikitext in the reflist
Comment 2 Roan Kattouw 2014-03-19 19:15:13 UTC
Adding references inside of references shouldn't be possible. That toolbar button is supposed to be hidden. Repurposing bug.

However, we should verify that we deal correctly with cases where this has already been done in wikitext.
Comment 3 Gerrit Notification Bot 2014-03-20 06:00:09 UTC
Change 119704 had a related patch set uploaded by Catrope:
Followup 861d097: actually exclude reference tool in reference dialog toolbar

https://gerrit.wikimedia.org/r/119704
Comment 4 Roan Kattouw 2014-03-20 06:00:31 UTC
(In reply to Roan Kattouw from comment #2)
> Adding references inside of references shouldn't be possible. That toolbar
> button is supposed to be hidden. Repurposing bug.
> 
Turned out to be an accidental overcorrection from fixing bug 62286.
Comment 5 Gerrit Notification Bot 2014-03-20 06:04:45 UTC
Change 119704 merged by jenkins-bot:
Followup 861d097: actually exclude reference tool in reference dialog toolbar

https://gerrit.wikimedia.org/r/119704
Comment 6 Rummana Yasmeen 2014-03-20 22:50:30 UTC
Verified the fix in test2:https://test2.wikipedia.org/w/index.php?title=Wmf19&veaction=edit

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links