Last modified: 2014-03-18 17:16:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64580, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 62580 - Lightbox exits when Esc is pressed with a modifier key
Lightbox exits when Esc is pressed with a modifier key
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
MultimediaViewer (Other open bugs)
unspecified
All All
: Unprioritized minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-03-12 21:14 UTC by Tisza Gergő
Modified: 2014-03-18 17:16 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Tisza Gergő 2014-03-12 21:14:47 UTC 
Steps to reproduce (on Chrome 33/Ubuntu 13 with Unity):
1. open lightbox
2. press and hold Alt
3. press Esc
4. release Alt

Expected result:
Task selection OS interface appears when pressing Alt+Tab, disappears when pressing Esc (which is the normal way of exiting the task selection interface without actually selecting a different task). Lightbox is undisturbed.

Actual result:
Task selection interface works as expected, but the lightbox is also closed.
Comment 1 Sorawee Porncharoenwase 2014-03-13 00:09:55 UTC 
This one is by design (// Close the interface all the way if the user pressed 'esc'). However, I agree that bug: 62578 -- "exit fullscreen by clicking the link provided by the browser" -- should be fixed.
Comment 2 Tisza Gergő 2014-03-13 00:20:53 UTC 
This is definitely not by design. Pressing Esc should close the lightbox when the user presses it with that intent; it should not close the lightbox when it is pressed as part of some completely different interaction which is not even related to the browser.

Granted, this is really a bug in Unity (that Esc press should not pass through to the browser in the first place), but it is an easy fix, just check for any modifier keys.

Note that the "Close the interface all the way if the user pressed 'esc'" comment refers to closing the lightbox when it is fullscreen mode and the user presses Esc (the browser default would be to just un-fullscreen). IMO that is a bug too, as it is contrary to user expectations and standard browser behavior, but that is related to bug 62578. This bug is not related to fullscreen at all.
Comment 3 Tisza Gergő 2014-03-13 00:23:28 UTC 
Ugh, I left out a reproduction step, no wonder it does not make sense. This is the correct version:

Steps to reproduce (on Chrome 33/Ubuntu 13 with Unity):
1. open lightbox
2. press and hold Alt
3. press Tab (opens task selection interface of the OS/window manager)
4. press Esc
5. release Alt
Comment 4 Sorawee Porncharoenwase 2014-03-13 00:26:51 UTC 
Ohhh I'm so sorry. I misread.
Comment 5 Gerrit Notification Bot 2014-03-17 21:15:20 UTC 
Change 119128 had a related patch set uploaded by Gergő Tisza:
Fix navigation issue with alt+esc on Ubuntu/Unity.

https://gerrit.wikimedia.org/r/119128
Comment 6 Gerrit Notification Bot 2014-03-18 09:18:36 UTC 
Change 119128 merged by jenkins-bot:
Fix navigation issue with alt+esc on Ubuntu/Unity.

https://gerrit.wikimedia.org/r/119128
Comment 7 Gilles Dubuc 2014-03-18 09:32:18 UTC 
Needs a mingle card
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links