Last modified: 2014-03-13 23:47:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64581, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 62581 - VisualEditor: [Regression wmf18] If you insert an image into the page with default settings, save, then re-open the page without refresh, JS errors on load
VisualEditor: [Regression wmf18] If you insert an image into the page with de...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal minor
: VE-deploy-2014-03-13
Assigned To: Moriel Schottlender
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-03-12 21:34 UTC by Rummana Yasmeen
Modified: 2014-03-13 23:47 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Screenshot (201.88 KB, image/png)
2014-03-12 21:34 UTC, Rummana Yasmeen 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Rummana Yasmeen 2014-03-12 21:34:16 UTC 
Created attachment 14795 [details]
Screenshot

Steps to reproduce:

1.Open a page with VE
2.Insert an image
3.Save the page
4.Reopen the page
5.Open the media settings for the image 

Observed Result:
The following error appears in the console and Media Settings dialog box cannot be closed:

Uncaught TypeError:Cannot read property 'width' of null
Uncaught TypeError:Cannot call method 'getItemFromData'of undefined.


See the screenshot attached

Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser: Chrome Version 26.0.1410.65 
Page:http://en.wikipedia.beta.wmflabs.org/w/index.php?title=12thmarchchrome
Comment 1 Gerrit Notification Bot 2014-03-13 04:07:39 UTC 
Change 118427 had a related patch set uploaded by Mooeypoo:
Fix regression bug 'default size' change on alignment

https://gerrit.wikimedia.org/r/118427
Comment 2 Gerrit Notification Bot 2014-03-13 21:07:42 UTC 
Change 118601 had a related patch set uploaded by Catrope:
Fix regression bug 'default size' change on alignment

https://gerrit.wikimedia.org/r/118601
Comment 3 Gerrit Notification Bot 2014-03-13 21:09:21 UTC 
Change 118427 merged by jenkins-bot:
Fix regression bug 'default size' change on alignment

https://gerrit.wikimedia.org/r/118427
Comment 4 James Forrester 2014-03-13 22:08:09 UTC 
Still occurring after the above patch. :-(

I've re-worded the bug title based on my understanding. The issue is probably in the binding of the variable – note that everything is fine as soon as you refresh the page, the problem is when you re-load VE on the same page (so re-using a lot of the VE running code).
Comment 5 James Forrester 2014-03-13 23:08:49 UTC 
(In reply to James Forrester from comment #4)
> Still occurring after the above patch. :-(

Belay that, now working. Probably browser cache issues. *sigh*

(Thanks, Moriel!)
Comment 6 Gerrit Notification Bot 2014-03-13 23:12:07 UTC 
Change 118601 merged by jenkins-bot:
Fix regression bug 'default size' change on alignment

https://gerrit.wikimedia.org/r/118601
Comment 7 Rummana Yasmeen 2014-03-13 23:47:13 UTC 
Verified the fix in production:https://en.wikipedia.org/w/index.php?title=User:RYasmeen_%28WMF%29/sandbox&veaction=edit
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links