Last modified: 2014-05-01 01:25:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64639, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 62639 - App crashes if you open a non-existing page
App crashes if you open a non-existing page
Status: RESOLVED FIXED
Product: Wikipedia App
Classification: Unclassified
Generic (Other open bugs)
Android (alpha)
All All
: High normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-14 09:25 UTC by Yuvi Panda
Modified: 2014-05-01 01:25 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Yuvi Panda 2014-03-14 09:25:04 UTC
Crash report:

USER_COMMENT=I just opened a nonexisting article from browser
ANDROID_VERSION=4.0.4
APP_VERSION_NAME=1.0-SNAPSHOT
BRAND=htc_europe
PHONE_MODEL=HTC Desire S
CUSTOM_DATA=
STACK_TRACE=java.lang.RuntimeException: java.lang.NullPointerException
at org.wikipedia.page.PageViewFragment$LeadSectionFetchTask.onCatch(PageViewFragment.java:267)
at org.wikipedia.concurrency.SaneAsyncTask$BackingAsyncTask.onPostExecute(SaneAsyncTask.java:96)
at android.os.AsyncTask.finish(AsyncTask.java:602)
at android.os.AsyncTask.access$600(AsyncTask.java:156)
at android.os.AsyncTask$InternalHandler.handleMessage(AsyncTask.java:615)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:154)
at android.app.ActivityThread.main(ActivityThread.java:4945)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:511)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:784)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:551)
at dalvik.system.NativeStart.main(Native Method)
Caused by: java.lang.NullPointerException
at org.wikipedia.page.PageViewFragment$LeadSectionFetchTask.processResult(PageViewFragment.java:241)
at org.wikipedia.page.PageViewFragment$LeadSectionFetchTask.processResult(PageViewFragment.java:224)
at org.wikipedia.ApiTask.performTask(ApiTask.java:19)
at org.wikipedia.concurrency.SaneAsyncTask$BackingAsyncTask.doInBackground(SaneAsyncTask.java:85)
at org.wikipedia.concurrency.SaneAsyncTask$BackingAsyncTask.doInBackground(SaneAsyncTask.java:79)
at android.os.AsyncTask$2.call(AsyncTask.java:264)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:305)
at java.util.concurrent.FutureTask.run(FutureTask.java:137)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:442)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:305)
at java.util.concurrent.FutureTask.run(FutureTask.java:137)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:150)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:264)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1076)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:569)
at java.lang.Thread.run(Thread.java:864)
java.lang.NullPointerException
at org.wikipedia.page.PageViewFragment$LeadSectionFetchTask.processResult(PageViewFragment.java:241)
at org.wikipedia.page.PageViewFragment$LeadSectionFetchTask.processResult(PageViewFragment.java:224)
at org.wikipedia.ApiTask.performTask(ApiTask.java:19)
at org.wikipedia.concurrency.SaneAsyncTask$BackingAsyncTask.doInBackground(SaneAsyncTask.java:85)
at org.wikipedia.concurrency.SaneAsyncTask$BackingAsyncTask.doInBackground(SaneAsyncTask.java:79)
at android.os.AsyncTask$2.call(AsyncTask.java:264)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:305)
at java.util.concurrent.FutureTask.run(FutureTask.java:137)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:442)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:305)
at java.util.concurrent.FutureTask.run(FutureTask.java:137)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:150)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:264)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1076)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:569)
at java.lang.Thread.run(Thread.java:864)
Comment 1 Sage Ross 2014-04-09 14:13:15 UTC
I ran into the same issue. I clicked a link from Notification email, and the link handler gave me the option to use the app. But when I opened it in the app it immediately crashed. I realized after opening the link in the browser instead that the page linked from the email had been moved with no redirect.
Comment 2 Yuvi Panda 2014-04-09 20:38:01 UTC
I guess a simple 'this page does not exist yet :(' message would do?
Comment 3 Sage Ross 2014-04-18 19:07:07 UTC
It may be essentially the same issue, but the app also crashes on any non-article page that doesn't have a mobile view. This includes most special pages, and pages in the Education_Program namespace.

A different message would be needed in those cases, since the problem is not that pages don't exist.
Comment 4 kenan wang 2014-04-21 23:00:17 UTC
Yes. We are working on this in the next 2 weeks.
Comment 5 Gerrit Notification Bot 2014-04-28 20:42:14 UTC
Change 130213 had a related patch set uploaded by Dbrant:
Fixed crash on nonexistent and Special pages (pages with no mobile view)

https://gerrit.wikimedia.org/r/130213
Comment 6 Gerrit Notification Bot 2014-04-28 22:05:29 UTC
Change 130226 had a related patch set uploaded by Dbrant:
Fixed crash on nonexistent pages.

https://gerrit.wikimedia.org/r/130226
Comment 7 Gerrit Notification Bot 2014-04-30 13:59:19 UTC
Change 130226 merged by jenkins-bot:
Fixed crash on nonexistent pages.

https://gerrit.wikimedia.org/r/130226
Comment 8 Gerrit Notification Bot 2014-04-30 14:55:30 UTC
Change 130213 abandoned by Dbrant:
Fixed crash on nonexistent and Special pages (pages with no mobile view)

Reason:
easier to create a new patch.

https://gerrit.wikimedia.org/r/130213
Comment 9 Sage Ross 2014-05-01 01:25:36 UTC
Resolved the latest build, but see bug 64691 related to the way it was resolved.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links