Last modified: 2014-04-23 11:57:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64644, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 62644 - do snack validation in changeop
do snack validation in changeop
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
master
All All
: High normal (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=backend p=5 s=2014-04-01
:
: 63114 (view as bug list)
Depends on:
Blocks: 62927 63114
  Show dependency treegraph
 
Reported: 2014-03-14 15:28 UTC by Lydia Pintscher
Modified: 2014-04-23 11:57 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Lydia Pintscher 2014-03-14 15:28:00 UTC
Snack validation should be triggered via the respective changeops. This will reduce code duplication. Make sure that we only validate when a snack actually changes.
Comment 1 Christopher Johnson 2014-04-01 13:45:45 UTC
*** Bug 63114 has been marked as a duplicate of this bug. ***
Comment 2 Gerrit Notification Bot 2014-04-04 13:19:04 UTC
Change 123860 had a related patch set uploaded by Daniel Kinzler:
(bug 62644) snak validation in ChangeOpMainSnak.

https://gerrit.wikimedia.org/r/123860
Comment 3 Gerrit Notification Bot 2014-04-04 15:25:47 UTC
Change 123872 had a related patch set uploaded by Daniel Kinzler:
(bug 62644) snak validation in ChangeOpReference

https://gerrit.wikimedia.org/r/123872
Comment 4 Gerrit Notification Bot 2014-04-07 12:20:26 UTC
Change 124317 had a related patch set uploaded by Daniel Kinzler:
(bug 62644) No snak val in ClaimModificationHelper

https://gerrit.wikimedia.org/r/124317
Comment 5 Gerrit Notification Bot 2014-04-09 14:10:41 UTC
Change 121689 merged by jenkins-bot:
(bug 62644) Move Snak validation into ChangeOps

https://gerrit.wikimedia.org/r/121689
Comment 6 Gerrit Notification Bot 2014-04-09 14:11:29 UTC
Change 123860 merged by jenkins-bot:
(bug 62644) snak validation in ChangeOpMainSnak.

https://gerrit.wikimedia.org/r/123860
Comment 7 Gerrit Notification Bot 2014-04-09 14:30:01 UTC
Change 123872 merged by jenkins-bot:
(bug 62644) Snak validation in more ChangeOps

https://gerrit.wikimedia.org/r/123872
Comment 8 Gerrit Notification Bot 2014-04-09 14:30:33 UTC
Change 124317 merged by jenkins-bot:
(bug 62644) No snak val in ClaimModificationHelper

https://gerrit.wikimedia.org/r/124317

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links