Last modified: 2014-05-13 20:17:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64756, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 62756 - VisualEditor: Its possible to input a fraction value (with decimal point) in image size which results into showing wrong size in the review changes section
VisualEditor: Its possible to input a fraction value (with decimal point) in ...
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Low minor
: VE-deploy-2014-05-01
Assigned To: Moriel Schottlender
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-03-17 22:25 UTC by Rummana Yasmeen
Modified: 2014-05-13 20:17 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Setting decimal value (59.45 KB, image/png)
2014-03-17 22:25 UTC, Rummana Yasmeen 		Details
The discrepancy in review changes section (48.46 KB, image/png)
2014-03-17 22:26 UTC, Rummana Yasmeen 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Rummana Yasmeen 2014-03-17 22:25:37 UTC 
Created attachment 14842 [details]
Setting decimal value

Steps to reproduce:

1.Open a page with VE
2.Insert a new image
3.Set the image size to a long value which becomes a number with scientific notation 
4.Now start deleting the value from right to left
5.Once you have deleted the scientific notation (e) and the number becomes a value with decimal point , click on "Apply Changes"

Observed Issue 1: it accepts that decimal value

6.Click on Save Page and go to "Review your Changes"

Observed Issue 2: The size value showing in the review changes section are completely different that what was set in step 5

See the screenshots attached

Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser: Chrome Version 26.0.1410.65 
OS: MAC OS X 10. 8. 5 
Page:http://en.wikipedia.beta.wmflabs.org/w/index.php?title=17marchff&veaction=edit
Comment 1 Rummana Yasmeen 2014-03-17 22:26:38 UTC 
Created attachment 14843 [details]
The discrepancy in review changes section
Comment 2 Moriel Schottlender 2014-05-08 17:50:26 UTC 
This doesn't happen anymore with the new MediaSizeWidget and the DimensionsWidget; they don't allow for decimal values at all.
Comment 3 Rummana Yasmeen 2014-05-13 20:17:18 UTC 
Verified the fix in production
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links