Last modified: 2014-11-17 23:29:35 UTC
Created attachment 14844 [details] Screenshot Steps to reproduce: 1.Open a page with VE 2.Open the link inspector 3.Now enter something invalid for link inspector , for example: File:Joo Chiat Place.jpg|Item 1 Observed Result: An error message appears for invalid page title , the style of the error message should be much more apparent like red See the screenshot attached Test Environment: http://en.wikipedia.beta.wmflabs.org/ Browser: Chrome Version 26.0.1410.65 OS: MAC OS X 10. 8. 5
Change 150297 had a related patch set uploaded by Palerdot: Fixed Bug 62761, added invalid link title style. https://gerrit.wikimedia.org/r/150297
I have made a fix to this bug. The gerrit patchset link is https://gerrit.wikimedia.org/r/#/c/150297/ Things done: A new CSS File 've.ui.MWLinkTargetInputWidget.css' is added to the path 'VisualEditor/modules/ve-mw/ui/styles/widgets'. Warning text style is added to the class '.ve-ui-mwLinkTargetInputWidget-warning' in this file. The CSS File is included in the style resources in the file 'VisualEditor.php'. Tested in latest stable firefox, chrome in Ubuntu 14.04. Please review the changes. I'm new to open source contribution, So let me know if I have done the fix to the bug in the right way. Thanks.
Created attachment 16097 [details] Screenshot of Fix for Bug 62761 This is the screenshot of the fix I have made for the bug 62761. The gerrit patch link is https://gerrit.wikimedia.org/r/#/c/150297/
Comment on attachment 16097 [details] Screenshot of Fix for Bug 62761 The color in the screenshot is red. I have changed the color to #d45353 to match the other warning elements in the mediawiki page.
Change 150297 merged by jenkins-bot: MWLinkTargetInputWidget: Add styles for invalid link titles https://gerrit.wikimedia.org/r/150297
All patches mentioned in this report were merged or abandoned - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?
Nice!
