Last modified: 2014-03-18 17:41:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64783, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 62783 - VisualEditor: Slugs don't animate when jumping from one to another
VisualEditor: Slugs don't animate when jumping from one to another
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2014-03-20
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-18 13:45 UTC by Ed Sanders
Modified: 2014-03-18 17:41 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ed Sanders 2014-03-18 13:45:50 UTC
1. Create a page with just a table
2. Focus the top slug (it animates)
3. Focus the bottom slug

Expected:
Top slug collapses, bottom slug expands

Observed:
Nothing

The logic for adding animation classes only checks to see if we've gone from in a slug to not in a slug, so we'll need to check if the slug has changed as well.
Comment 1 Gerrit Notification Bot 2014-03-18 13:46:12 UTC
Change 119287 had a related patch set uploaded by Esanders:
Check if newly focused slug is different to previous slug

https://gerrit.wikimedia.org/r/119287
Comment 2 Gerrit Notification Bot 2014-03-18 17:41:17 UTC
Change 119287 merged by jenkins-bot:
Check if newly focused slug is different to previous slug

https://gerrit.wikimedia.org/r/119287

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links