Last modified: 2014-03-20 11:49:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64798, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 62798 - Consolidate watchlist and recent changes hook query code in Wikibase Client
Consolidate watchlist and recent changes hook query code in Wikibase Client
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
WikidataClient (Other open bugs)
master
All All
: Low normal (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=backend p=0
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-18 18:30 UTC by Aude
Modified: 2014-03-20 11:49 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Aude 2014-03-18 18:30:00 UTC
In the SpecialWatchlistQuery hook, we can now make use of FormOptions, which would allow us to hook in more cleanly and share more code with recent changes query hook.

The wikibase code that handles watchlist query was written when:

1) options were not exposed to the hook
2) were arrays instead of objects.
Comment 1 Aude 2014-03-20 11:49:59 UTC
perhaps we can even find a way to abstract / improve handling of these queries more generally.

it's a bit icky the way we modify the queries.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links