Last modified: 2014-03-26 16:34:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64834, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 62834 - A multiline HTML comment after a heading leads to the wikitext line being sent through as plain text


Summary:	A multiline HTML comment after a heading leads to the wikitext line being sen...

Status:	RESOLVED FIXED

Product:	Parsoid
Classification:	Unclassified
Component:	General (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal
Target Milestone:	---
Assigned To:	Gabriel Wicke

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-03-19 14:52 UTC by Amir E. Aharoni
Modified:	2014-03-26 16:34 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Amir E. Aharoni 2014-03-19 14:52:24 UTC

For an example see:
https://en.wikipedia.org/wiki/User:Amire80/heading-comment?veaction=edit

There is an HTML comment that begins after a heading.

This page is rendered correctly, but in the VE the heading is displayed incorrectly and there is a line break character after it.

This is a rather esoteric case, but such comments do happen. They are used in GSoC templates among other things; for an example see the "Deliverables" section heading at
https://www.mediawiki.org/w/index.php?title=User:Vikassy/GSoC14&oldid=931677

Comment 1 James Forrester 2014-03-19 18:14:29 UTC

Input wikitext:

| ==Foo==<!--Bar-->
| Baz
| 
| ==Foo==<!--
| Bar-->
| Baz

Output Parsoid HTML:

| <h2 data-parsoid="…">Foo</h2><!--Bar-->
| <p data-parsoid="…">Baz</p>
| 
| <p data-parsoid="…">==Foo==<!--
| Bar-->
| Baz</p>

Possibly related to bug 60829?

Comment 2 Gerrit Notification Bot 2014-03-25 22:17:50 UTC

Change 120952 had a related patch set uploaded by Subramanya Sastry:
(Bug 62834) Accept multi-line comments in inline_breaks check

https://gerrit.wikimedia.org/r/120952

Comment 3 Gerrit Notification Bot 2014-03-26 15:39:15 UTC

Change 120952 merged by jenkins-bot:
(Bug 62834) Accept multi-line comments in inline_breaks check

https://gerrit.wikimedia.org/r/120952

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links