Last modified: 2014-04-03 21:59:25 UTC
Created attachment 14862 [details] Observed behaviour on URL System used: * OSX 10.9.1. * Firefox 27.0.1 Steps to reproduce: 1. Enable Beta feature Typography refresh on https://nl.wikipedia.org/wiki/Speciaal:Voorkeuren?uselang=en#mw-prefsection-betafeatures 2. Visit https://nl.wikipedia.org/wiki/Neil_deGrasse_Tyson Observe that reference IDs are way above the line and flow into the previous line which decreases readability of text. Expected: No text should flow into previous lines and decrease readability of text. Additional information: * Screenshot attached.
Than
Is this related to the change "The superscript (sup) line-height is now set to 0, to fix a long-standing problem with reference numbers affecting the leading", mentioned in [[:mw:Typography Refresh]]? It says we changed this to resolve bug 49965.
The other option here is that there is some kind of local nlwiki style causing this. When I view the same article on enwiki, dewiki, and eswiki I see no such bug, and nlwiki has the following in its Common.css: sup, .reference { vertical-align: text-top; position: relative; font-size: 0.80em; top: -5px; } sub { line-height: 0; }
Steven is correct. This is caused by local wiki css at https://nl.wikipedia.org/wiki/MediaWiki:Common.css. The solution to the bug is to just remove the custom CSS (or adjust it if they prefer).
(In reply to Steven Walling from comment #2) > Is this related to the change "The superscript (sup) line-height is now set > to 0, to fix a long-standing problem with reference numbers affecting the > leading" (Slightly off-topic, but let me ask anyway) Is there a reason why it's 0 instead of 1em? We have a CSS rule for this at pl.wp too, ours uses 1em and it serves us well. :) https://pl.wikipedia.org/wiki/MediaWiki:Common.css #bodyContent sup, #bodyContent sub { line-height: 1em; }
The problematic rule has now been moved to core MediaWiki in a slightly different form; I think this will no longer be causing any issues, but the local CSS override can be removed anyway as a similar fix will be applied in core for all skins.
I've removed the local css, see here: https://nl.wikipedia.org/w/index.php?title=MediaWiki%3ACommon.css&diff=40947882&oldid=39889709
Thanks. Let's mark this bug as resolved, then.
