Last modified: 2014-03-31 22:43:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64854, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 62854 - Confirm flock() works as expected in HHVM
Confirm flock() works as expected in HHVM
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Aaron Schulz
: hhvm
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-19 22:22 UTC by Ori Livneh
Modified: 2014-03-31 22:43 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ori Livneh 2014-03-19 22:22:09 UTC
Aaron is concerned that a subtle difference between the Zend interpreter and HHVM's implementations of flock will prove problematic.

https://github.com/facebook/hhvm/blob/master/hphp/runtime/ext/ext_file.cpp#L353
Comment 1 Aaron Schulz 2014-03-31 22:43:52 UTC
After a closer look at the man page and after to talking on #hhvm a bit I think it should be fine:

"If a process uses open(2) (or similar) to obtain more than one descriptor for the same file, these descriptors are treated independently by flock(). An attempt to lock the file using one of these file descriptors may be denied by a lock that the calling process has already placed via another descriptor."

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links