Last modified: 2014-04-04 14:31:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64878, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 62878 - jquery.makeCollapsible incompatible with jquery.tablesorter
jquery.makeCollapsible incompatible with jquery.tablesorter
Status: NEW
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.23.0
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-20 17:44 UTC by mdowdell
Modified: 2014-04-04 14:31 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description mdowdell 2014-03-20 17:44:21 UTC
Example of issue: [https://en.wikipedia.org/w/index.php?title=User:Mdowdell/sandbox&oldid=600478437]

As can be seen in [https://en.wikipedia.org/w/index.php?title=User:Mdowdell/sandbox&oldid=600478437#mw-collapsible_mw-collapsed_sortable] the mw-collapsed sortable table hides the second row used for sorting. However, the collapsible table [https://en.wikipedia.org/w/index.php?title=User:Mdowdell/sandbox&oldid=600478437#collapsble_collapsed_sortable] show the second row when uncollapsing the table.
Comment 1 mdowdell 2014-03-21 00:11:26 UTC
I've fixed this bug for Wikia, although jquery.makeCollapsible is different between 1.19 and the current release. The fix for 1.19 can be seen at https://github.com/Wikia/app/pull/2675/files

With the changes made in Bug 30352, this is just a matter of removing the conditional at http://git.wikimedia.org/blob/mediawiki%2Fcore.git/master/resources%2Fjquery%2Fjquery.makeCollapsible.js#L63 and always select every row. The row with the toggle should be excluded in the next conditional on L68.

I'd like to fix this myself if possible, I'm just a little unsure of how to do so with gerrit so it might take a little while for me to get around to submitting a patch.
Comment 2 Bartosz Dziewoński 2014-03-21 00:59:30 UTC
Thanks for the report!

Here's a quickstart Gerrit guide:
https://www.mediawiki.org/wiki/Gerrit/Getting_started

Here's a detailed, extremely boring one:
https://www.mediawiki.org/wiki/Gerrit/Tutorial

And if you can't get it to work, there's a service that lets you directly upload patches in standard formats: http://tools.wmflabs.org/gerrit-patch-uploader/

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links