Last modified: 2014-11-20 20:45:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64884, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 62884 - VisualEditor: Prefer HTML5 Web Storage over cookies for state not needed server-side


Summary:	VisualEditor: Prefer HTML5 Web Storage over cookies for state not needed serv...

Status:	PATCH_TO_REVIEW

Product:	VisualEditor
Classification:	Unclassified
Component:	Technical Debt (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Low enhancement
Target Milestone:	---
Assigned To:	Editing team bugs – take if you're interested!

URL:
Whiteboard:
Keywords:	performance

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-03-20 18:33 UTC by Krinkle
Modified:	2014-11-20 20:45 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Krinkle 2014-03-20 18:33:49 UTC

Cookies can be HTTP-only, but there is no JS-only flag. So any cookies we set, are sent to the server in every request.

http://..dev/
http://..dev/wiki/Main_Page
http://..dev/w/index.php?title=Main_Page&action=edit
http://..dev/w/api.php...
etc.

All these have the following header when enabling $wgVisualEditorShowBetaWelcome

Cookie: alphawikiUserID=1; alphawikiUserName=Root; alphawiki_session=*; ve-beta-welcome-dialog=1;

By using Web Storage (e.g. localStorage or sessionStorage) we keep it out of the http stack, and read/writes themselves after faster with localStorage as well.

Comment 1 Gerrit Notification Bot 2014-11-20 20:45:50 UTC

Change 174798 had a related patch set uploaded by Alex Monk:
Use localStorage to store ve-beta-welcome-dialog

https://gerrit.wikimedia.org/r/174798

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links