Last modified: 2014-10-19 17:43:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64888, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 62888 - refactor "upload file" step to mediawiki_selenium gem
refactor "upload file" step to mediawiki_selenium gem
Status: NEW
Product: Wikimedia
Classification: Unclassified
Quality Assurance (Other open bugs)
unspecified
All All
: Low major (vote)
: ---
Assigned To: Nobody - You can work on this!
zfilipin
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-20 19:19 UTC by Chris McMahon
Modified: 2014-10-19 17:43 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Chris McMahon 2014-03-20 19:19:41 UTC
I updated the MobileFrontend repo such that the there is a step "When(/^upload file (.+)$/) do |file_name|" that exactly matches the same step in the UploadWizard repo.  The MobileFrontend version was broken in several ways, notably for Chrome. 

There is also a step in the MobileFrontend repo "When(/^upload bogus file (.+)$/) do |file_name|" that should also probably move to shared gem. 

Rather than duplicate code, we should put these identical steps in the shared steps of the mediawiki_selenium gem. 

If we want to do further refactoring, we should do it in the mediawiki_selenium gem and not in the individual repos.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links