Last modified: 2014-03-25 21:18:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64932, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 62932 - unusual URL changes Firefox vs. Chrome
unusual URL changes Firefox vs. Chrome
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
: browser-test-bug
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-21 17:11 UTC by Chris McMahon
Modified: 2014-03-25 21:18 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Chris McMahon 2014-03-21 17:11:45 UTC
In the course of shoring up the Chrome builds for browser tests, I noticed this unusual behavior. This may be a WONTFIX, but I thought I would report it in case. 

Run the browser test mainmenu.feature. The step in question is: 

Given(/^I am on the "(.+)" page$/) do |article|
  visit(ArticlePage, :using_params => {:article_name => article})
end

and the |article| param is "Main Page" (not "Main_Page")  

Watch the URLs for "Main_Page" as the test runs

In Firefox the URL changes from 
"Main_Page" to "Main Page"

In Chrome the URL changes from 

"Main_Page" to "Main%20Page"

The issue for the browser tests was that checking the URL depends on the browser reporting correctly that it was done processing all of the URL changes and had reached its final state.  This was true for Firefox, but Chrome seems to be reporting final state before all the URL switching, thus causing the test to fail for Chrome only. 

I added an implicit wait to the test so that the test would pass without an explicit sleep() command, but I thought the URL munging was unusual enough to report.
Comment 1 Bingle 2014-03-21 17:15:09 UTC
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1793
Comment 2 Jon 2014-03-24 17:32:17 UTC
So the %20 and ' ' inconsistency is a Chrome/Firefox inconsistency. Nothing we can really do there. Anything without the '_' will cause a redirect. We should probably avoid the redirect where we can....
Comment 3 Gerrit Notification Bot 2014-03-24 17:32:33 UTC
Change 120564 had a related patch set uploaded by Jdlrobson:
Avoid redirects when visiting URLS in browser tests

https://gerrit.wikimedia.org/r/120564
Comment 4 Gerrit Notification Bot 2014-03-25 15:36:10 UTC
Change 120564 merged by jenkins-bot:
Avoid redirects when visiting URLS in browser tests

https://gerrit.wikimedia.org/r/120564

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links