Last modified: 2014-03-21 22:08:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64934, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 62934 - VisualEditor: [Regression pre-wmf20] TOC widget doesn't tear itself down correctly, throws Cannot call method 'teardown' of undefined while trying to save a page on Betalabs


Summary:	VisualEditor: [Regression pre-wmf20] TOC widget doesn't tear itself down corr...

Status:	RESOLVED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	Editing Tools (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High normal
Target Milestone:	VE-deploy-2014-03-27
Assigned To:	Trevor Parscal

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-03-21 18:00 UTC by Rummana Yasmeen
Modified:	2014-03-21 22:08 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Screenshot (127.55 KB, image/png) 2014-03-21 18:00 UTC, Rummana Yasmeen	Details
Add an attachment (proposed patch, testcase, etc.)

Description Rummana Yasmeen 2014-03-21 18:00:13 UTC

Created attachment 14873 [details]
Screenshot

Steps to reproduce:

1.Open a page with VE
2.Add a text
3.Try to Save the page


Observed Result:
An error appears : Uncaught TypeError: Cannot call method 'teardown' of undefined
The page seems to be in readmode but the cursor still appears on the page

See the screenshot attached

Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser: Chrome Version 26.0.1410.65 
OS: MAC OS X 10. 8. 5 
Page:http://en.wikipedia.beta.wmflabs.org/wiki/Toc_issue

Comment 1 Trevor Parscal 2014-03-21 18:04:08 UTC

This error has to do with code that looks like this:

if ( this.surface.mwTocWidget ) {
    this.mwTocWidget.teardown();
}

which needs to be rewritten to look like:


if ( this.surface.mwTocWidget ) {
    this.mwTocWidget.surface.teardown();
}

Comment 2 Trevor Parscal 2014-03-21 18:04:46 UTC

Oops... I meant:

if ( this.surface.mwTocWidget ) {
    this.surface.mwTocWidget.teardown();
}

Comment 3 Gerrit Notification Bot 2014-03-21 20:33:19 UTC

Change 120070 had a related patch set uploaded by Jforrester:
Fix a typo that causes crashes when using the wrong symbol for mwTocWidget

https://gerrit.wikimedia.org/r/120070

Comment 4 Gerrit Notification Bot 2014-03-21 20:34:56 UTC

Change 120070 merged by jenkins-bot:
Fix a typo that causes crashes when using the wrong symbol for mwTocWidget

https://gerrit.wikimedia.org/r/120070

Comment 5 Rummana Yasmeen 2014-03-21 22:08:54 UTC

Verified the fix in betalabs

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links