Last modified: 2014-11-03 08:08:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64952, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 62952 - Hovercards: disable NavigationPopups (Gadget) if Hovercards Beta Feature is enabled
Hovercards: disable NavigationPopups (Gadget) if Hovercards Beta Feature is e...
Status: REOPENED
Product: MediaWiki extensions
Classification: Unclassified
Popups (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Prateek Saxena
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-22 04:31 UTC by Prateek Saxena
Modified: 2014-11-03 08:08 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Prateek Saxena 2014-03-22 04:31:00 UTC
Call the global `disablePopups()` if present
Comment 1 Gerrit Notification Bot 2014-03-22 04:38:48 UTC
Change 120188 had a related patch set uploaded by Prtksxna:
Disable NavigationPopups (Gadget) is Popups (Extension) is enabled

https://gerrit.wikimedia.org/r/120188
Comment 3 Gerrit Notification Bot 2014-06-06 10:12:22 UTC
Change 120188 merged by jenkins-bot:
Disable NavigationPopups (Gadget) if Popups (Extension) is enabled

https://gerrit.wikimedia.org/r/120188
Comment 4 Prateek Saxena 2014-06-24 10:08:07 UTC
The merged patch did not work as intended.
Comment 5 Gerrit Notification Bot 2014-06-24 10:09:09 UTC
Change 141668 had a related patch set uploaded by Prtksxna:
disablenavpop: Use winow:load instead of dom:ready

https://gerrit.wikimedia.org/r/141668
Comment 6 Andre Klapper 2014-08-17 11:23:08 UTC
Status here: https://gerrit.wikimedia.org/r/#/c/141668/ still awaiting review
Comment 7 Gerrit Notification Bot 2014-08-20 14:12:20 UTC
Change 141668 merged by jenkins-bot:
disablenavpop: Use winow onload instead of dom ready

https://gerrit.wikimedia.org/r/141668
Comment 8 Quiddity 2014-10-11 03:03:39 UTC
Re-opening, as I'm getting Hovercards and Navpopups at the same time, at mediawiki.org.  Firefox 32.

Also, the settings menu is only showing me options for "Simple" and "Disable previews", no matter what I try or change.

(Note: I removed navpopups from my global.js and that did Not fix either of the problems.)
Comment 9 Prateek Saxena 2014-11-03 08:08:42 UTC
I need help resolving this bug. I am unable to understand the order in which things are executing, though the order should not be affecting this at all.

The code in the Extension [1] and my common.js [2] are the same and yet it does not work from the extension. Any help is welcome.

[1] http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FPopups.git/7b5fbab16011f1770f69248dd3e4d99bea7e4b4f/resources%2Fext.popups.disablenavpop.js
[2] https://en.wikipedia.org/wiki/User:Prtksxna/common.js

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links