Last modified: 2014-04-04 14:12:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64955, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 62955 - Install puppet-lint and create a puppet-lint job
Install puppet-lint and create a puppet-lint job
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
wmf-deployment
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-22 13:13 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-04-04 14:12 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Antoine "hashar" Musso (WMF) 2014-03-22 13:13:21 UTC
We should get puppet-lint installed from rubygems on the Jenkins labs slave then get a job to run it on all puppet repositories. http://puppet-lint.com/ .

Luckily puppet supports the gem provider :-}
Comment 1 Tim Landscheidt 2014-03-22 17:00:16 UTC
puppet-lint is available as an Ubuntu package:

| Package: puppet-lint
| State: not installed
| Version: 0.1.7-1
| Priority: optional
| Section: universe/ruby
| Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
| Architecture: all
| Uncompressed Size: 85.0 k
| Depends: ruby | ruby-interpreter, puppet-common
| Suggests: rake
| Description: check puppet manifests for style guide conformity
|  Checks your Puppet manifests against the Puppet Labs style guide and alerts you
|  to any discrepancies. 
 
|  This program checks spacing, indentation, whitespace, quoting, conditionals and
|  classes.
| Homepage: https://github.com/rodjek/puppet-lint/
Comment 2 Antoine "hashar" Musso (WMF) 2014-03-22 20:25:50 UTC
0.1.7 is from two years ago, we can use gem in labs :-]
Comment 3 Gerrit Notification Bot 2014-03-24 10:07:41 UTC
Change 120498 had a related patch set uploaded by Hashar:
contint: install puppet-lint from rubygems on labs

https://gerrit.wikimedia.org/r/120498
Comment 4 Gerrit Notification Bot 2014-04-02 14:21:29 UTC
Change 120498 abandoned by Hashar:
contint: install puppet-lint from rubygems on labs

Reason:
puppet-lint debian package got back ported. See RT #7154

https://gerrit.wikimedia.org/r/120498
Comment 5 Antoine "hashar" Musso (WMF) 2014-04-04 14:12:44 UTC
We have puppet-lint using the backported Debian package. I have added template in Jenkins Job Builder and added puppet lint to operations/puppet and translatewiki git repositories.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links