Last modified: 2014-04-23 23:02:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64991, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 62991 - coordinate_import.py: allow non-wikipedia sources


Summary:	coordinate_import.py: allow non-wikipedia sources

Status:	RESOLVED DUPLICATE of bug 62438

Product:	Pywikibot
Classification:	Unclassified
Component:	Wikidata (Other open bugs)
Version:	core-(2.0)
Hardware:	All All

Importance:	Unprioritized normal
Target Milestone:	---
Assigned To:	Ricordisamoa

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-03-23 21:51 UTC by Merlijn van Deen (test)
Modified:	2014-04-23 23:02 UTC (History)
CC List:	1 user (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Merlijn van Deen (test) 2014-03-23 21:51:15 UTC

1) getSource / cacheSources should be moved to a more general class, so all WD bots can use it, and
2) getSource / cacheSources is now wikipedia-specific, and I think there is already a non-WP-specific version around in one of the other WD bots.

Comment 1 Gerrit Notification Bot 2014-04-16 09:10:13 UTC

Change 126213 had a related patch set uploaded by Ricordisamoa:
create a new WikidataBot class for cacheSources() and getSource() for claimit.py, coordinate_import.py and harvest_template.py

https://gerrit.wikimedia.org/r/126213

Comment 2 Gerrit Notification Bot 2014-04-20 20:47:04 UTC

Change 126213 merged by jenkins-bot:
create a new WikidataBot class for cacheSources() and getSource() for claimit.py, coordinate_import.py and harvest_template.py

https://gerrit.wikimedia.org/r/126213

Comment 3 Merlijn van Deen (test) 2014-04-20 20:47:47 UTC


*** This bug has been marked as a duplicate of bug 62438 ***

Comment 4 Ricordisamoa 2014-04-23 19:28:38 UTC

(In reply to Merlijn van Deen from comment #3)
> 
> *** This bug has been marked as a duplicate of bug 62438 ***

Even if a single patch resolved both, I am not sure they are exactly the same.

Comment 5 Merlijn van Deen (test) 2014-04-23 20:44:29 UTC

I considered them 'the same' as they were both bugs about refactoring getSource/cacheSource into a common library -- but you could consider the non-WP-source as a 'feature request' for coordinate_import.py. Considering it 'res/fixed' is also fine with me :-)

Comment 6 Ricordisamoa 2014-04-23 23:02:06 UTC

Actually, I don't care much of this. Just leave it as it is :-)

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links