Last modified: 2014-05-09 19:51:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64994, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 62994 - Hovercards: empty cards should never be generated


Summary:	Hovercards: empty cards should never be generated

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	Popups (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal major (vote)
Target Milestone:	---
Assigned To:	Prateek Saxena

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-03-24 04:43 UTC by Prateek Saxena
Modified:	2014-05-09 19:51 UTC (History)
CC List:	5 users (show)

See Also:	63792
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
testcase (89.16 KB, image/png) 2014-03-24 04:43 UTC, Prateek Saxena	Details
Screenshot of Hovercard and Navpopup for same link (168.69 KB, image/png) 2014-04-10 21:51 UTC, Quiddity	Details
Wiktionary screenshot of Hovercard and Navpopup for same link (112.06 KB, image/png) 2014-04-10 21:52 UTC, Quiddity	Details
Add an attachment (proposed patch, testcase, etc.)

Description Prateek Saxena 2014-03-24 04:43:16 UTC

Sometimes it seems there are empty dialogs. Can we avoid showing the hover cards in these situations or fix this? [1]

[1] https://www.mediawiki.org/w/index.php?title=Talk:Beta_Features/Hovercards&topic_postId=rri0cyxphqyu8cp1&workflow=rrc19ij5nimkme01#flow-post-rri0cyxphqyu8cp1

Comment 1 Prateek Saxena 2014-03-24 04:43:57 UTC

Created attachment 14888 [details]
testcase

Comment 2 Quiddity 2014-04-10 21:51:54 UTC

Created attachment 15078 [details]
Screenshot of Hovercard and Navpopup for same link

Comment 3 Quiddity 2014-04-10 21:52:38 UTC

Created attachment 15079 [details]
Wiktionary screenshot of Hovercard and Navpopup for same link

Comment 4 Quiddity 2014-04-10 22:05:59 UTC

One of the problems seems to be, that it is ignoring text that appears after a section heading. 
This is a site-wide problem for En.Wiktionary content, because they don't use intro sentences at all.

Would it help to change the "exintro" parameter of [[mw:Extension:TextExtracts#API]]? (I'm not sure what other repercussions that might have)

Comment 5 Yuvi Panda 2014-04-22 10:45:48 UTC

So two things here:

1. If the extract we get back is empty, we just should not display a card. This is a HoverCards issue that should be easy to fix.
2. If an extract is empty when it shouldn't be, file separate bugs against TextExtracts.

Comment 6 Gerrit Notification Bot 2014-04-24 12:32:09 UTC

Change 129402 had a related patch set uploaded by Prtksxna:
Stop Popups from being generated if extract is empty

https://gerrit.wikimedia.org/r/129402

Comment 7 Gerrit Notification Bot 2014-04-28 09:59:48 UTC

Change 129402 merged by jenkins-bot:
Stop Popups from being generated if extract is empty

https://gerrit.wikimedia.org/r/129402

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links