Last modified: 2014-06-12 17:38:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65002, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63002 - Nosetests / codecoverage packages missing from wikimetrics' setup
Nosetests / codecoverage packages missing from wikimetrics' setup
Status: NEW
Product: Analytics
Classification: Unclassified
Wikimetrics (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-24 10:34 UTC by christian
Modified: 2014-06-12 17:38 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description christian 2014-03-24 10:34:39 UTC
When installing wikimetrics through vagrant, nosetests and codecoverage are not
installed per default. So one cannot run the nosetests due to missing
dependencies.

Can we install nosetests/codecoverage in vagrant's wikimetrics role?
Comment 1 nuria 2014-03-24 13:05:22 UTC
I believe vagrant roles do not setup testing infrastructure for roles via puppet. You are expected to pip install nose. At least that is the case in the roles I have installed. 

I am not sure this is a bug.
Comment 2 christian 2014-03-24 14:45:25 UTC
(In reply to nuria from comment #1)
> You are expected to pip install nose.

Then the bug is that this necessary step is not documented anywhere :-)
Comment 3 christian 2014-03-24 16:09:02 UTC
(In reply to christian from comment #2)
> Then the bug is that this necessary step is not documented anywhere :-)

Rubbish, Christian!

No need to change the documentation, when we can fix the install procedure and
install nosetests, and codecoverage. Thereby making wikimetrics development
easier.

(As I've been told that Andrew opposed, I asked him via email, and it turned
out that he does not oppose installing nosetests and codecoverage
to vagrant's wikimetrics role.)
So let's have nosetests and codecoverage installed in vagrant's wikimetrics
role. \o/
Comment 4 Bingle 2014-03-24 16:53:32 UTC
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/analytics/cards/cards/1494
Comment 5 christian 2014-03-24 21:21:07 UTC
Just to keep track of what was said in private emails, one suggestion was to
turn the current $debug into something more generic:

   $environment = ‘development’,
   …
   if $environment == ‘development’ {
       $debug = true
       exec { ‘install_wikimetrics_test_dependencies’:
       …
       }
   }
   else {
       $debug = false
   }
Comment 6 nuria 2014-03-24 22:00:40 UTC
This would cleanly replace code we have like the following:

if (debug) 
     # change some config setting X to Y

With:
 if (development)
   # load development config, it already has X=Y

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links