Last modified: 2014-04-15 13:59:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65009, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63009 - PHP Fatal error: Call to a member function getEntity() on a non-object in repo/includes/EditEntity.php on line 488
PHP Fatal error: Call to a member function getEntity() on a non-object in re...
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=backend p=3 s=2014-03-18
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-24 14:05 UTC by Aude
Modified: 2014-04-15 13:59 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Aude 2014-03-24 14:05:07 UTC
also an issue on line 492.

@note - this is spotted in the mw1.23-wmf19 branch.  line numbers might be different in master

PHP Fatal error:  Call to a member function getEntity() on a non-object in /Library/WebServer/Documents/php-master/extensions/Wikibase/repo/in      cludes/EditEntity.php on line 488

PHP Stack trace:                                                          
1. {main}() /Library/WebServer/Documents/php-master/api.php:0       
2. ApiMain->execute() /Library/WebServer/Documents/php-master/api.php:86
3. ApiMain->executeActionWithErrorHandling() /Library/WebServer/Documents/php-4. ApiMain->executeAction() /Library/WebServer/Documents/php-master/includes/api/ApiMain.php:363  
5. Wikibase\Api\SetClaim->execute() /Library/WebServer/Documents/php-master/includes/api/ApiMain.php:899 
6. Wikibase\Api\ModifyClaim->saveChanges() /Library/WebServer/Documents/php-master/extensions/Wikibase/repo/includes/api/SetClaim.php:69
7. Wikibase\Api\ApiWikibase->attemptSaveEntity() /Library/WebServer/Documents/php-master/extensions/Wikibase/repo/includes/api/ModifyClaim.php:79
8. Wikibase\EditEntity->attemptSave() /Library/WebServer/Documents/php-master/extensions/Wikibase/repo/includes/api/ApiWikibase.php:513
9. Wikibase\EditEntity->applyPreSaveChecks() /Library/WebServer/Documents/php-master/extensions/Wikibase/repo/includes/EditEntity.php:726   
10. Wikibase\EditEntity->fixEditConflict() /Library/WebServer/Documents/php-master/extensions/Wikibase/repo/includes/EditEntity.php:823
Comment 1 Gerrit Notification Bot 2014-03-24 14:25:17 UTC
Change 120529 had a related patch set uploaded by Hoo man:
Don't assume we have a conflict if no base rev is known in EditEntity

https://gerrit.wikimedia.org/r/120529
Comment 2 Aude 2014-03-24 16:26:33 UTC
the issue I had was an edge case, I think with my item missing in the wb_entity_per_page table.

the problem shouldn't happen on wikidata, but never know.

I think there are places in EditEntity where it can be made more robust for this and who knows what other edge cases.
Comment 3 Gerrit Notification Bot 2014-03-26 12:31:28 UTC
Change 120529 merged by jenkins-bot:
Don't assume we have a conflict if no base rev is known in EditEntity

https://gerrit.wikimedia.org/r/120529
Comment 4 Marius Hoch 2014-03-26 16:10:22 UTC
Aude: I guess we can consider this fixed?!
Comment 5 Marius Hoch 2014-03-26 16:14:13 UTC
Marking as resolved per Aude

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links