Last modified: 2014-03-25 21:39:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65085, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63085 - VisualEditor: [Regression pre-wmf20] Cannot save a page after undoing inserting reference on it
VisualEditor: [Regression pre-wmf20] Cannot save a page after undoing inserti...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: Highest major
: VE-deploy-2014-03-27
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-25 19:26 UTC by Rummana Yasmeen
Modified: 2014-03-25 21:39 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
screenshot (139.76 KB, image/png)
2014-03-25 19:26 UTC, Rummana Yasmeen
Details
screenshot 2 (164.54 KB, image/png)
2014-03-25 19:31 UTC, Rummana Yasmeen
Details

Description Rummana Yasmeen 2014-03-25 19:26:37 UTC
Created attachment 14903 [details]
screenshot

There are wide varieties of type errors I get for undoing typing references in different way.I will try to document each cases in this same bug report:


Case 1:

Steps to reproduce:

1.Insert a reference with text for example : reference[1]
2.Press "Undo"

Error 1:
Uncaught TypeError: Cannot read property 'length' of undefined 

3.Place the cursor at the end of the text

Error 2:
Uncaught Error: ve.dm.Document.getNodeFromOffset(): offset 12 is out of bounds 


Case 2:

1.Insert two references with text , for example:
reference [1]
reference [2]

2.Now keep on pressing Undo untill the page gets empty

Errors:
Uncaught TypeError: Cannot read property 'length' of undefined VM484:296
Uncaught Error: Offset could not be translated to a DOM element and offset: 12 VM484:447
Uncaught Error: Invalid end offset: 21 VM484:252
Uncaught Error: Unbalanced input passed to document 

In both cases, after the Undo action , clicking on "Save Page" does not do anything.
Comment 1 Rummana Yasmeen 2014-03-25 19:31:17 UTC
Created attachment 14904 [details]
screenshot 2
Comment 2 Gerrit Notification Bot 2014-03-25 20:48:34 UTC
Change 120874 had a related patch set uploaded by Catrope:
Rename stray this.refGroup usage to this.group in MWReferenceModel

https://gerrit.wikimedia.org/r/120874
Comment 3 Gerrit Notification Bot 2014-03-25 21:09:02 UTC
Change 120874 merged by jenkins-bot:
Rename stray this.refGroup usage to this.group in MWReferenceModel

https://gerrit.wikimedia.org/r/120874
Comment 4 Rummana Yasmeen 2014-03-25 21:39:36 UTC
Verified the fix in Betalabs: http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Reference_numbering&veaction=edit

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links