Last modified: 2014-04-15 20:30:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65094, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 63094 - OOjs UI: MenuWidget.off('select') disables default behavior
OOjs UI: MenuWidget.off('select') disables default behavior
Status: RESOLVED WORKSFORME
Product: OOjs UI
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Normal minor
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-03-26 01:29 UTC by Tisza Gergő
Modified: 2014-04-15 20:30 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Tisza Gergő 2014-03-26 01:29:53 UTC 
Steps to reproduce:
1. load a page with an OoUiInlineMenuWidget (I used the one in MultimediaViewer master, behind the "Use this file" button)
2. get the menu widget behind it, run off('select') (with the current version of  MultimediaViewer, this can be done from the console via mw.mmv.bootstrap.viewer.ui.panel.fileReuse.tabs.embed.embedWtSizeSwitch.getMenu().off('select') )

Expected result: any custom handlers are removed, but default behavior is unaffected

Actual result: default behavior is disabled - the selection (the content of the .oo-ui-inlineMenuWidget-handle class) does not change when selecting an option.
Comment 1 Tisza Gergő 2014-04-08 00:56:58 UTC 
I think this is fixed, I have seen code using unqualified off() work without problem recently.
Comment 2 James Forrester 2014-04-15 20:30:35 UTC 
Confirmed from my testing; sorry for the problem!
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links