Last modified: 2014-05-30 18:33:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65132, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 63132 - VisualEditor: Cannot close the Media Settings dialog as the error Uncaught TypeError: Object #<VeDmMWMathNode> has no method 'getCaptionNode' appears in the console


Summary:	VisualEditor: Cannot close the Media Settings dialog as the error Uncaught Ty...

Status:	VERIFIED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	Editing Tools (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High normal
Target Milestone:	VE-deploy-2014-05-08
Assigned To:	Ed Sanders

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-03-26 19:01 UTC by Rummana Yasmeen
Modified:	2014-05-30 18:33 UTC (History)
CC List:	6 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
screenshot (181.85 KB, image/png) 2014-03-26 19:01 UTC, Rummana Yasmeen	Details
Add an attachment (proposed patch, testcase, etc.)

Description Rummana Yasmeen 2014-03-26 19:01:15 UTC

Created attachment 14917 [details]
screenshot

Steps to reproduce:


1.Open a page with VE
2.Open the math inspector
3.Keep it open
4.Insert an image
5.Select the image
6.Click on undo 
7.Click on the media settings icon that is still appearing at the right corner of the page

Observed Result:

The Media Settings dialog box appears with empty caption field .An error appears in the console: 
Uncaught TypeError: Object #<VeDmMWMathNode> has no method 'getCaptionNode'

Also, you will not be able to close the Media Settings dialog box and will get stuck at this step.


See the screenshot attached.

Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser: Chrome Version 26.0.1410.65 & FF 25
OS: MAC OS X 10. 8. 5 
Page:http://en.wikipedia.beta.wmflabs.org/wiki/User:RYasmeen_%28WMF%29?veaction=edit

Comment 1 Roan Kattouw 2014-03-26 22:18:00 UTC

This seems to be because MediaEditDialog is launched for an MWMathNode, which shouldn't be possible. Assigned to Trevor as the fact that we even got here is a bug in the tools system.

MediaEditDialog also shouldn't crash in this case, but Moriel is already going to merge the insertion and edit dialogs, so that should take care of that issue.

Comment 2 James Forrester 2014-05-30 17:49:00 UTC

I believe that this is now fixed – please confirm.

Comment 3 Rummana Yasmeen 2014-05-30 18:33:23 UTC

Yes, Checked in production,appears to be fixed.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links