Last modified: 2014-11-05 22:28:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65158, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 63158 - VisualEditor: Parameter add icon remains enabled in empty transclusion dialog box
VisualEditor: Parameter add icon remains enabled in empty transclusion dialog...
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal minor
: VE-deploy-2014-10-29 (1.25wmf6)
Assigned To: Alex Monk
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-03-27 00:52 UTC by Rummana Yasmeen
Modified: 2014-11-05 22:28 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Screenshot (23.88 KB, image/png)
2014-03-27 00:52 UTC, Rummana Yasmeen 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Rummana Yasmeen 2014-03-27 00:52:13 UTC 
Created attachment 14932 [details]
Screenshot

Steps to reproduce:

1.Open a page with VE
2.Go to Insert>Transclusion
3.Insert a template for example : The Cite web
4.Click on "Show options"
5.Keep on clicking on trash icon until you delete all the parameters and the template itself

Observed Result:

Observe that, even if there is no template in the dialog box , the add parameter button remains enabled , it should be disabled if there is o template.

See the screenshot attached.

Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser: Chrome Version 26.0.1410.65 & FF 25
OS: MAC OS X 10. 8. 5
Comment 1 Gerrit Notification Bot 2014-10-23 18:51:43 UTC 
Change 168379 had a related patch set uploaded by Alex Monk:
Disable parameter add icon when there's no transclusion parts

https://gerrit.wikimedia.org/r/168379
Comment 2 etonkovidova 2014-10-27 19:59:12 UTC 
Confirmed in betalabs and test2.
Comment 3 Gerrit Notification Bot 2014-10-27 20:39:49 UTC 
Change 168379 merged by jenkins-bot:
Disable parameter add icon when there's no transclusion parts

https://gerrit.wikimedia.org/r/168379
Comment 4 Rummana Yasmeen 2014-11-05 22:28:30 UTC 
Verified the fix in production
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links