Last modified: 2014-06-27 01:58:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65162, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63162 - Hovercards: When image is not masked by pin should use main popup height
Hovercards: When image is not masked by pin should use main popup height
Status: ASSIGNED
Product: MediaWiki extensions
Classification: Unclassified
Popups (Other open bugs)
unspecified
Macintosh Mac OS X 10.9
: Normal normal (vote)
: ---
Assigned To: Vibha Bamba
:
: 65242 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-27 01:50 UTC by Jared Zimmerman (WMF)
Modified: 2014-06-27 01:58 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
top of image clipped unnecessarily (160.55 KB, image/png)
2014-03-27 01:50 UTC, Jared Zimmerman (WMF)
Details
cropping issue (1.03 MB, image/png)
2014-03-27 23:24 UTC, Jared Zimmerman (WMF)
Details

Description Jared Zimmerman (WMF) 2014-03-27 01:50:27 UTC
Created attachment 14935 [details]
top of image clipped unnecessarily

Only when the image is masked by the pin should its height be stretched taller than the popup.
Comment 1 Prateek Saxena 2014-03-27 13:48:08 UTC
This is a decision that Vibha and I consciously took. As the proportions of these images can vary we have a fixed size box and the image stretches/clips to fit that area. Keeps the Hovercard clean. 

Any suggestions are welcome!
Comment 2 Jared Zimmerman (WMF) 2014-03-27 23:22:31 UTC
We might want to revisit this, but we can talk more
Comment 3 Jared Zimmerman (WMF) 2014-03-27 23:24:52 UTC
Created attachment 14950 [details]
cropping issue
Comment 4 Jared Zimmerman (WMF) 2014-03-27 23:25:37 UTC
I attached another issue about cropping, masking, and enlarging, unsure if its the same issue.
Comment 5 Prateek Saxena 2014-03-27 23:45:58 UTC
Yes it is the same issue, enlarging an image to fit a a specific size and ratio.
Comment 6 Vibha Bamba 2014-04-16 23:47:47 UTC
Jared's point is about photo composition, duly noted. Lets revisit this once the the major usability and visual bugs have been fixed. Assigning it to myself so I can manage bugs that have visual impact for the user.
Comment 7 Quiddity 2014-06-27 01:58:20 UTC
*** Bug 65242 has been marked as a duplicate of this bug. ***
Comment 8 Quiddity 2014-06-27 01:58:38 UTC
Merging comments from bug 65242:

Attachment 15363 [details] (logo crop)
Attachment 15364 [details] (album crop)
Attachment 15365 [details] (portrait crop)

(Quiddity wrote)
> Images are cropped in Hovercards, which sometimes looks quite bad.
> Particularly logos (screenshot 1) and album covers (screenshot 2).
> Occasionally portraits of people will be cut off right in their hairline
> (screenshot 3).
> 
> The best of our images, are already scrupulously cropped/framed, so it would
> be ideal to present to readers, exactly the images that our editors intended.


(Eduard Braun wrote)
> This is also an issue for all graphical illustrations like diagrams,
> chemical structure formulae, geometric sketches, etc.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links