Last modified: 2014-09-23 12:56:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65228, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63228 - prevent import of items
prevent import of items
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
master
All All
: Highest major (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=backend p=8
:
Depends on: 65256
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-28 13:17 UTC by Lydia Pintscher
Modified: 2014-09-23 12:56 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Lydia Pintscher 2014-03-28 13:17:05 UTC
Importing items is horribly broken. We need to prevent it.
Comment 1 Kunal Mehta (Legoktm) 2014-04-07 03:50:04 UTC
I assume that prevention is just meant to be a temporary measure until import of items is fixed?
Comment 2 Lydia Pintscher 2014-04-07 16:07:11 UTC
Until someone can come up with a concept for importing that is actually workable and maintains data integrity.
Comment 3 Kunal Mehta (Legoktm) 2014-04-14 03:19:54 UTC
Makes sense. In that case, you can just add a hook for 'TitleQuickPermissions' in wmf-config/CommonSettings.php to deny any user the import right in the item and property namespaces.
Comment 4 Marius Hoch 2014-04-22 21:43:13 UTC
(In reply to Kunal Mehta (Legoktm) from comment #3)
> Makes sense. In that case, you can just add a hook for
> 'TitleQuickPermissions' in wmf-config/CommonSettings.php to deny any user
> the import right in the item and property namespaces.

Sadly this is by far not this easy as core is only checking for the permissions in general, but not whether the user can import to a specific title (or namespace). I did some initial hacking in Wikibase but I'm not sure how to adopt core (that's super evil legacy code again...).
Comment 5 Vogone 2014-04-25 21:12:20 UTC
Mhm, is there any reason why this is such a high priority bug? I mean, since the import right is restricted to administrators anyway, and these are usually acting responsibly, a simple notice on Special:Import asking them not to import from ns0 should do it as well until a solution like Legoktm proposed becomes real instead of removing functionality (import of non-items) from the wikis.
Comment 6 Lydia Pintscher 2014-04-25 21:16:27 UTC
Because that is not happening and people are complaining again and again about broken pages.
Comment 7 Vogone 2014-04-25 21:34:34 UTC
How can you know that before having tested it with a notice? To my knowledge, none exists yet so how they should know?
Comment 8 Kunal Mehta (Legoktm) 2014-04-25 21:39:45 UTC
Lets find out: [[d:MediaWiki:Import-summary]].
Comment 9 Gerrit Notification Bot 2014-05-14 13:08:19 UTC
Change 133227 had a related patch set uploaded by Daniel Kinzler:
Prevent import of entities to avoid ID conflicts

https://gerrit.wikimedia.org/r/133227

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links