Last modified: 2014-04-03 17:34:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65233, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 63233 - Using <section> prevents from inheriting CSS
Using <section> prevents from inheriting CSS
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User preferences (Other open bugs)
1.23.0
All All
: Unprioritized normal (vote)
: 1.23.0 release
Assigned To: Bartosz Dziewoński
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-03-28 19:06 UTC by Luis Felipe Schenone
Modified: 2014-04-03 17:34 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Screen of the bug in Chrome 31 (164.03 KB, image/png)
2014-03-28 19:07 UTC, Luis Felipe Schenone 		Details
Screen of the bug in Firefox 25 (169.26 KB, image/png)
2014-03-28 19:07 UTC, Luis Felipe Schenone 		Details
Screen of the bug in Safari 6 (157.72 KB, image/png)
2014-03-28 19:08 UTC, Luis Felipe Schenone 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Luis Felipe Schenone 2014-03-28 19:06:22 UTC 
In includes/templates/Usercreate.php, there is a part that reads:

<section class="mw-form-header">
<?php $this->html( 'header' ); ?>
</section>

For some reason, the content put between the <section></section> tags does not inherit the CSS from its parents, with ugly consequences. For instance, when the ConfirmEdit extension is activated, and QuestyCaptcha is used, an input field is inserted between the <section></section> tags, which doesn't inherit CSS and thus looks different from the rest of the fields.

I've seen this bug in Chrome 33, Firefox 25 and Safari 6 (screens attached). This bug is probably not due to MediaWiki, but a short Google search didn't suggest that it's a browser issue either.

So anyway, rather than complicating ourselves too much, I suggest to simply change the section tags for divs.

Here is the Gerrit patch: https://gerrit.wikimedia.org/r/#/c/121291/
Comment 1 Luis Felipe Schenone 2014-03-28 19:07:03 UTC 
Created attachment 14960 [details]
Screen of the bug in Chrome 31
Comment 2 Luis Felipe Schenone 2014-03-28 19:07:25 UTC 
Created attachment 14961 [details]
Screen of the bug in Firefox 25
Comment 3 Luis Felipe Schenone 2014-03-28 19:08:05 UTC 
Created attachment 14962 [details]
Screen of the bug in Safari 6
Comment 4 Luis Felipe Schenone 2014-03-28 19:09:34 UTC 
Oops! The link to the Gerrit patch is this one: https://gerrit.wikimedia.org/r/#/c/121292/
Comment 5 Bartosz Dziewoński 2014-03-28 19:37:58 UTC 
Can you link me to somewhere with this set up, so I can test?

I don't see how using 'section' would cause issues, my guess would be that this is caused by something else, or maybe overly specific CSS somewhere.

Note also that FancyCaptcha is currently special-cased in core and is the only one that looks somewhat nice.
Comment 6 Luis Felipe Schenone 2014-03-28 20:34:13 UTC 
http://testwiki.lfschenone.com/index.php?title=Special:UserLogin&type=signup

Have you tried reproducing the bug?
Comment 7 Gerrit Notification Bot 2014-03-28 20:43:32 UTC 
Change 121842 had a related patch set uploaded by Bartosz Dziewoński:
mediawiki.ui: Do not depend on divs being present inside .mw-ui-vform

https://gerrit.wikimedia.org/r/121842
Comment 8 Bartosz Dziewoński 2014-03-28 20:47:27 UTC 
This is actually caused by some silly CSS in mediawiki.ui.
Comment 9 Luis Felipe Schenone 2014-03-29 15:21:17 UTC 
Do you know which one? When I first found the problem, I tried fixing it by altering the CSS via the console, but after a while of failing I got tired and went for the other approach.
Comment 10 Bartosz Dziewoński 2014-03-29 15:31:09 UTC 
The stuff I submitted a patch for above :) https://gerrit.wikimedia.org/r/121842
Comment 11 Gerrit Notification Bot 2014-04-02 21:23:32 UTC 
Change 121842 merged by jenkins-bot:
mediawiki.ui: Do not depend on divs being present inside .mw-ui-vform

https://gerrit.wikimedia.org/r/121842
Comment 12 Bartosz Dziewoński 2014-04-03 17:34:17 UTC 
Fixed on master.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links