Last modified: 2014-04-16 00:10:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65246, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 63246 - Styling issues in search overlay
Styling issues in search overlay
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-03-28 23:54 UTC by Jon
Modified: 2014-04-16 00:10 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Exhibit 1 (48.32 KB, image/png)
2014-03-28 23:54 UTC, Jon 		Details
Exhibit 2 (30.77 KB, image/png)
2014-03-28 23:55 UTC, Jon 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Jon 2014-03-28 23:54:13 UTC 
Created attachment 14967 [details]
Exhibit 1

There are a few styling issues with the search overlay in stable.
Comment 1 Bingle 2014-03-28 23:55:09 UTC 
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1818
Comment 2 Jon 2014-03-28 23:55:37 UTC 
Created attachment 14968 [details]
Exhibit 2
Comment 3 Ryan Kaldari 2014-03-29 00:45:02 UTC 
Did some investigation and this is due to one of the deprecated hacks in stable:

// Deprecated rules
.stable {
  // this makes sure mobile browsers don't zoom on inputs (minimum resulting
  // font size has to be 16px)
  // header font size is kept the same to make it consistent with the search input
  input,
  textarea,
  .header,
  .overlay-header {
    font-size: round( 1em / @fontScalingFactor, 2 );
  }
}

Working around it would require adding a bunch of similar hacks elsewhere. My suggestion would be to promote TypographyNew.less to stable instead and get rid of the rule above.
Comment 4 Gerrit Notification Bot 2014-04-05 00:14:10 UTC 
Change 124034 had a related patch set uploaded by JGonera:
Fix styling of "No page with this title" in search

https://gerrit.wikimedia.org/r/124034
Comment 5 Gerrit Notification Bot 2014-04-16 00:08:24 UTC 
Change 124034 merged by jenkins-bot:
Fix styling of "No page with this title" in search

https://gerrit.wikimedia.org/r/124034
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links