Last modified: 2014-07-07 14:27:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65247, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63247 - Flow: Viewing a difflink to a deleted Topic gives Error page
Flow: Viewing a difflink to a deleted Topic gives Error page
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-29 00:36 UTC by Quiddity
Modified: 2014-07-07 14:27 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Quiddity 2014-03-29 00:36:42 UTC
This line was in my watchlist:

* (diff) Wikipedia talk:WikiProject Breakfast; 06:03 . . (+63)‎ . . Sj (talk | contribs) edited a comment on This topic was deleted by Dougweller.

Clicking the (diff) link sent me to https://en.wikipedia.org/w/index.php?title=Wikipedia_talk:WikiProject_Breakfast&workflow=ropnaopuy0b5yp2w&topic_oldRevision=rrpzj5dmf5xpum28&topic_newRevision=rrpzij853a0phqfi&action=compare-post-revisions 
which shows me this:

"Wikimedia Foundation
Error
Our servers are currently experiencing a technical problem. This is probably temporary and should be fixed soon. Please try again in a few minutes. ...

PHP fatal error in /usr/local/apache/common-local/php-1.23wmf19/extensions/Flow/includes/Templating.php line 452:
Argument 1 passed to Flow\Templating::getContent() must be an instance of Flow\Model\AbstractRevision, null given, called in /usr/local/apache/common-local/php-1.23wmf19/extensions/Flow/includes/View/Revision.php on line 581 and defined "

(Note: I know the moderation/deletion system is in the process of being reevaluated, so this bug is likely to be cleared up by that work. I'll add more details on expected behaviour (when a non-admin tries to view deleted content) another day.)
Comment 1 Sam Reed (reedy) 2014-07-07 14:24:58 UTC
Wonder if this is still occuring...

Just dug the relevant stack trace out of the archives

[2014-03-29 00:17:00] Catchable fatal error: Argument 1 passed to Flow\Templating::getContent() must be an instance of Flow\Model\AbstractRevision, null given, called in /usr/local/apache/common-local/php-1.23wmf19/extensions/Flow/includes/View/Revision.php on line 581 and defined at /usr/local/apache/common-local/php-1.23wmf19/extensions/Flow/includes/Templating.php on line 452
Server: mw1043
Method: GET
URL: http://en.wikipedia.org/w/index.php?title=Wikipedia_talk:WikiProject_Breakfast&workflow=ropnaopuy0b5yp2w&topic_oldRevision=rrpzj5dmf5xpum28&topic_newRevision=rrpzij853a0phqfi&action=compare-post-revisions
Backtrace:
#0 /usr/local/apache/common-local/php-1.23wmf19/extensions/Flow/includes/Templating.php(452): Flow\Templating::getContent()
#1 /usr/local/apache/common-local/php-1.23wmf19/extensions/Flow/includes/View/Revision.php(581): Flow\Templating->getContent(NULL, 'wikitext')
#2 /usr/local/apache/common-local/php-1.23wmf19/extensions/Flow/includes/View/Revision.php(205): Flow\View\PostRevisionView->getDiffViewHeader(Object(Flow\Model\PostRevision), Object(Flow\Model\PostRevision))
#3 /usr/local/apache/common-local/php-1.23wmf19/extensions/Flow/includes/Block/Topic.php(461): Flow\View\RevisionView->renderDiffViewAgainst('rrpzj5dmf5xpum2...', false)
#4 /usr/local/apache/common-local/php-1.23wmf19/extensions/Flow/includes/Block/Block.php(127): Flow\Block\TopicBlock->render(Object(Flow\Templating), Array)
#5 /usr/local/apache/common-local/php-1.23wmf19/extensions/Flow/includes/View.php(80): Flow\Block\AbstractBlock->onRender('compare-post-re...', Object(Flow\Templating), Array)
#6 /usr/local/apache/common-local/php-1.23wmf19/extensions/Flow/Hooks.php(250): Flow\View->show(Object(Flow\WorkflowLoader), 'compare-post-re...')
#7 [internal function]: FlowHooks::onPerformAction(Object(OutputPage), Object(Article), Object(Title), Object(User), Object(WebRequest), Object(MediaWiki))
#8 /usr/local/apache/common-local/php-1.23wmf19/includes/Hooks.php(206): call_user_func_array('FlowHooks::onPe...', Array)
#9 /usr/local/apache/common-local/php-1.23wmf19/includes/GlobalFunctions.php(4011): Hooks::run('MediaWikiPerfor...', Array, NULL)
#10 /usr/local/apache/common-local/php-1.23wmf19/includes/Wiki.php(410): wfRunHooks('MediaWikiPerfor...', Array)
#11 /usr/local/apache/common-local/php-1.23wmf19/includes/Wiki.php(292): MediaWiki->performAction(Object(Article), Object(Title))
#12 /usr/local/apache/common-local/php-1.23wmf19/includes/Wiki.php(588): MediaWiki->performRequest()
#13 /usr/local/apache/common-local/php-1.23wmf19/includes/Wiki.php(447): MediaWiki->main()
#14 /usr/local/apache/common-local/php-1.23wmf19/index.php(49): MediaWiki->run()
#15 /usr/local/apache/common-local/w/index.php(3): require('/usr/local/apac...')
#16 {main}
Comment 2 Sam Reed (reedy) 2014-07-07 14:27:14 UTC
Link works now. Closing as FIXED

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links