Last modified: 2014-04-02 13:55:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65257, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63257 - Migrate MwEmbedSupport to use JSON i18n
Migrate MwEmbedSupport to use JSON i18n
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
TimedMediaHandler (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: i18n
Depends on:
Blocks: 63258
  Show dependency treegraph
 
Reported: 2014-03-29 12:43 UTC by Siebrand Mazeland
Modified: 2014-04-02 13:55 UTC (History)
11 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Siebrand Mazeland 2014-03-29 12:43:01 UTC
Gerrit change #121615 migrated MwEmbedSupport to use JSON i18n. This was reverted in Gerrit change #121889 because it caused "PHP Notice:  Undefined index: en in /data/project/apache/common-local/php-master/extensions/MwEmbedSupport/MwEmbedResourceManager.php on line 49".

According to MaxSem, this extension implements a home-brewed ResourceLoader. Because I have no knowledge of this, I'm skipping migration to JSON i18n and have reported this bug report. If someone has knowledge of this extension, please make it work with JSON files :).
Comment 1 Gerrit Notification Bot 2014-03-29 13:45:37 UTC
Change 121950 had a related patch set uploaded by Siebrand:
Add support for JSON files using messageDir.

https://gerrit.wikimedia.org/r/121950
Comment 2 Gerrit Notification Bot 2014-03-29 20:56:56 UTC
Change 121976 had a related patch set uploaded by Siebrand:
Migrate to JSON i18n

https://gerrit.wikimedia.org/r/121976
Comment 3 Andre Klapper 2014-03-31 09:30:39 UTC
Siebrand: I'd appreciate if tickets were created when creating new components in Bugzilla. I'm going to remove this "mwembedsupport" component again.
Comment 4 Siebrand Mazeland 2014-03-31 10:19:14 UTC
André, not sure what you mean. Can you elaborate, please?
Comment 5 Andre Klapper 2014-03-31 10:59:49 UTC
Siebrand: I appreciate Bugzilla tickets when creating new components and waiting for feedback first. See https://www.mediawiki.org/wiki/Bug_management/Project_Maintainers#To_add_a_project_or_component - traditionally everybody has been doing what (s)he thinks is right with best intention, but in the long run missing coordination and missing transparency create a mess in BZ taxonomy. :)
In this specific case I once talked to Multimedia and they prefer remaining mwEmbed* stuff under the TMH umbrella in Bugzilla (though this might welcome clarification in the TMH component description).
Comment 6 Siebrand Mazeland 2014-03-31 11:20:46 UTC
(In reply to Andre Klapper from comment #5)
> Siebrand: I appreciate Bugzilla tickets when creating new components and
> waiting for feedback first. See
> https://www.mediawiki.org/wiki/Bug_management/
> Project_Maintainers#To_add_a_project_or_component - traditionally everybody
> has been doing what (s)he thinks is right with best intention, but in the
> long run missing coordination and missing transparency create a mess in BZ
> taxonomy. :)
> In this specific case I once talked to Multimedia and they prefer remaining
> mwEmbed* stuff under the TMH umbrella in Bugzilla (though this might welcome
> clarification in the TMH component description).

Okay. Thanks. I do find it confusing that multiple extensions have the same component, as that makes it hard to find.
Comment 7 Tisza Gergő 2014-03-31 19:24:25 UTC
(In reply to Siebrand Mazeland from comment #6)
> Okay. Thanks. I do find it confusing that multiple extensions have the same
> component, as that makes it hard to find.

You can go the mediawiki.org page which should always have the same name as the extension ( https://www.mediawiki.org/wiki/Extension:MwEmbedSupport ) and look at the bugzilla links at the bottom of the infobox.

Merging/splitting extensions is relatively easy, merging/splitting Bugzilla components is hard, so I don't think it makes sense to keep up an 1:1 relation all the time. (No opinion on TMH/MwEmbed* specifically.)
Comment 8 Gerrit Notification Bot 2014-04-02 08:11:08 UTC
Change 121950 merged by jenkins-bot:
Add support for JSON files using messageDir

https://gerrit.wikimedia.org/r/121950
Comment 9 Gerrit Notification Bot 2014-04-02 13:34:19 UTC
Change 121976 merged by jenkins-bot:
Migrate to JSON i18n

https://gerrit.wikimedia.org/r/121976

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links