Last modified: 2014-03-30 15:03:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65259, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63259 - Template's CSS code shows on page when editing
Template's CSS code shows on page when editing
Status: RESOLVED INVALID
Product: VisualEditor
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-29 12:50 UTC by Stryn
Modified: 2014-03-30 15:03 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
picture of the bug (47.81 KB, image/png)
2014-03-29 12:50 UTC, Stryn
Details

Description Stryn 2014-03-29 12:50:48 UTC
Created attachment 14971 [details]
picture of the bug

Template's html code shows on page when editing. I don't know should we change something with our templates on fi-wiki, or is it possible to fix in VisualEditor.

How to reproduce:
1) go to https://fi.wikipedia.org/wiki/Australian_Grand_Prix_2014?veaction=edit
2) see the 2 templates on the bottom of the page

If you need more information, feel free to ask.
Comment 1 Derk-Jan Hartman 2014-03-29 13:17:25 UTC
Well, https://fi.wikipedia.org/w/index.php?title=Malline:Australian_Grand_Prix&action=edit


| lisätyylit = ...styleinfo..." cellpadding="2" cellspacing="5"

What is that, and what gave anyone the idea that that would ever work ? :D
Comment 2 kimmo.virtanen 2014-03-30 14:59:38 UTC
Hi, i think that the idea of the "lisätyylit" is to add css inline rules to div and stuff after that is to end css-rules and add some table attributes. However it has never worked because there is div element and not table. It also broke resulting html-code even it seemed to work.

Reason why visual editor broke is the mismatching doublequotes in expanded template result (in lisätyyli param: '... both" cellpadding="2" cellspacing="5"':

-- Clip --
<div class="NavFrame " style=" margin: auto; background-color: #ffffff; border: 1px #aaaaaa solid; margin: 0.5em auto auto auto; width: 600px; text-align: center; font-size: 95%; clear: both;; background-color: #FFFFFF; color: #000000; width: auto;"><div class="NavHead" style="display:block;text-align:center;background-color: #F3D161;">
-- Clip --

I fixed some templates with this change and my guess that all of F1-templates can be fixed with same way: 
- https://fi.wikipedia.org/w/index.php?title=Malline%3ABrasilian_Grand_Prix&diff=13955778&oldid=13575504

However there seems to be little delay before change can be seen in visual editor after template is fixed and i could not find any way to purge visual editors cache. 

If it ok for stryn i think that this bug can be closed.
Comment 3 Stryn 2014-03-30 15:03:16 UTC
Closed. Thanks for your investigating.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links