Last modified: 2014-04-01 16:09:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65268, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 63268 - searchGetNearMatchBeforeHook - incorrect parameter specification
searchGetNearMatchBeforeHook - incorrect parameter specification
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CirrusSearch (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-03-29 20:55 UTC by Bob Dye
Modified: 2014-04-01 16:09 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Bob Dye 2014-03-29 20:55:27 UTC 
The MediaWiki 'SearchGetNearMatchBefore' hook passes the second parameter ($titleResult) by reference.

Because it is not defined as being by reference in the searchGetNearMatchBeforeHook function definition, the result is never returned to MediaWiki.
Comment 1 Gerrit Notification Bot 2014-03-31 20:39:45 UTC 
Change 122551 had a related patch set uploaded by Chad:
Fix incorrect hook usage, second parameter is a reference

https://gerrit.wikimedia.org/r/122551
Comment 2 Gerrit Notification Bot 2014-04-01 13:29:01 UTC 
Change 122551 merged by jenkins-bot:
Fix incorrect hook usage, second parameter is a reference

https://gerrit.wikimedia.org/r/122551
Comment 3 Chad H. 2014-04-01 16:09:11 UTC 
Thanks for the report! This is now fixed in master.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links