Last modified: 2014-11-12 09:44:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65308, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63308 - Split EntityIdFormatter from EntityIdValueFormatter
Split EntityIdFormatter from EntityIdValueFormatter
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=backend p=5 s=2014-04-01
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-31 16:17 UTC by Aude
Modified: 2014-11-12 09:44 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Aude 2014-03-31 16:17:58 UTC
We have various "EntityId" formatters that conflate and combine functionality for formatting both EntityIdValues and EntityIds.

ValueFormatters for DataValues contain some specific behavior, like exception for DataValueMismatch which can take two arguments:

1) expected value type
2) actual value type that's attempted to be formatted

it would be odd for it to have multiple expected values, one of which is not actually a DataValue.

EntityIdValue formatters can reuse most/much of the EntityId formatter functionality but should behave more consistently as value formatters.
Comment 1 Daniel Kinzler 2014-04-24 10:02:35 UTC
As discussed via mail: the EntityIdValueFormatter should use an EntityIdFormatter.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links