Last modified: 2014-04-07 17:37:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65317, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 63317 - Search overlay makes unnecessary requests for watch star status
Search overlay makes unnecessary requests for watch star status
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-03-31 18:25 UTC by Jon
Modified: 2014-04-07 17:37 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jon 2014-03-31 18:25:34 UTC 
When logged in on English Wikipedia perform a search for "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa" that doesn't match any results

An API request for:
https://en.m.wikipedia.org/w/api.php?format=json&action=query&titles=%7C%7C&prop=info&inprop=watched

is made. This is completely unnecessary.

It would be good if whilst fixing this bug we also created WatchApi that extends Api and removed a lot of the legacy code here...
Comment 1 Bingle 2014-03-31 18:30:09 UTC 
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1823
Comment 2 Gerrit Notification Bot 2014-04-07 02:46:17 UTC 
Change 124281 had a related patch set uploaded by Theopolisme:
Search: Prevent unneeded API requests when there aren't any titles

https://gerrit.wikimedia.org/r/124281
Comment 3 Gerrit Notification Bot 2014-04-07 17:37:48 UTC 
Change 124281 merged by jenkins-bot:
Search: Prevent unneeded API request when there aren't any titles

https://gerrit.wikimedia.org/r/124281
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links