Last modified: 2014-04-02 14:15:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65322, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 63322 - ec2id puppet fact can yield some arbitrary HTML


Summary:	ec2id puppet fact can yield some arbitrary HTML

Status:	RESOLVED FIXED

Product:	Wikimedia Labs
Classification:	Unclassified
Component:	Infrastructure (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-03-31 19:30 UTC by Antoine "hashar" Musso (WMF)
Modified:	2014-04-02 14:15 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Antoine "hashar" Musso (WMF) 2014-03-31 19:30:05 UTC

I found out deployment-salt.eqiad.wmflabs puppet master got broken.  Looking at ./puppet.conf and ./puppet.conf.d/10-self.conf I noticed the certname = fields had some HTML such as:

<html>
<title>error 500</title>
blah some error message

Which ... break puppet!



Our factor in modules/base/lib/facter/ec2id.rb has no error handling:

       Facter::Util::Resolution.exec("curl http://169.254.169.254/1.0/meta-data/instance-id 2> /dev/null").chomp


Whenever the executed commands has an error it should bails out.  Hopefully curl exit with non 0 whenever it receives a 500.

Comment 1 Gerrit Notification Bot 2014-04-02 06:56:43 UTC

Change 123168 had a related patch set uploaded by Hashar:
Labs: prevent ec2id fact from returing errors

https://gerrit.wikimedia.org/r/123168

Comment 2 Gerrit Notification Bot 2014-04-02 13:28:39 UTC

Change 123168 merged by Andrew Bogott:
Labs: prevent ec2id fact from returing errors

https://gerrit.wikimedia.org/r/123168

Comment 3 Tim Landscheidt 2014-04-02 14:15:35 UTC

Appears to have been fixed (cf. also Gerrit change #123221).

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links