Last modified: 2014-11-12 23:43:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65341, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 63341 - VisualEditor: Remove transclusion node if we were just going to set it to empty content
VisualEditor: Remove transclusion node if we were just going to set it to emp...
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal minor
: VE-deploy-2014-11-05 (1.25wmf7)
Assigned To: Alex Monk
:
: 63340 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-04-01 00:32 UTC by Rummana Yasmeen
Modified: 2014-11-12 23:43 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Screenshot (122.21 KB, image/png)
2014-04-01 00:32 UTC, Rummana Yasmeen 		Details
Screenshot (122.21 KB, image/png)
2014-04-01 00:33 UTC, Rummana Yasmeen 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Rummana Yasmeen 2014-04-01 00:32:56 UTC 
Created attachment 14989 [details]
Screenshot

Steps to reproduce:

1.Open a page with VE
2.Go to Insert>Template
3.Click on Show Options
4.Click on the trash icon.
5.Click on "Add Content"

Observed Result:
The "Insert transclusion" button becomes enabled and an empty transclusion with empty content gets added upon clicking on it.


See the screenshot attached

Test Environment: https://test2.wikipedia.org/
Browser: Chrome Version 26.0.1410.65 
OS: MAC OS X 10. 8. 5
Comment 1 Rummana Yasmeen 2014-04-01 00:33:18 UTC 
Created attachment 14990 [details]
Screenshot
Comment 2 Rummana Yasmeen 2014-10-23 19:06:55 UTC 
Also, there is an error in the console:
Uncaught TypeError: Cannot read property 'length' of null
Comment 3 Alex Monk 2014-10-23 21:14:50 UTC 
*** Bug 63340 has been marked as a duplicate of this bug. ***
Comment 4 Roan Kattouw 2014-10-24 02:26:45 UTC 
See also bug 63340, which was duped to this one but is actually subtly different: it's about when the only part is a TemplatePlaceholderPage
Comment 5 Gerrit Notification Bot 2014-10-29 01:10:36 UTC 
Change 169638 had a related patch set uploaded by Alex Monk:
MWTransclusionModel: Exclude parts serialising to '' from the plain object

https://gerrit.wikimedia.org/r/169638
Comment 6 Gerrit Notification Bot 2014-10-29 23:20:50 UTC 
Change 169638 merged by jenkins-bot:
MWTransclusionModel: Exclude parts serialising to '' from the plain object

https://gerrit.wikimedia.org/r/169638
Comment 7 Rummana Yasmeen 2014-11-05 23:25:59 UTC 
Verified the fix in test2
Comment 8 Rummana Yasmeen 2014-11-12 23:43:23 UTC 
Verified the fix in production
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links