Last modified: 2014-06-17 21:35:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65343, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 63343 - checkLess.php doesn't validate skin styles
checkLess.php doesn't validate skin styles
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Maintenance scripts (Other open bugs)
1.23.0
All All
: High normal (vote)
: ---
Assigned To: Sam Smith
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-04-01 01:47 UTC by Matthew Flaschen
Modified: 2014-06-17 21:35 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Matthew Flaschen 2014-04-01 01:47:54 UTC 
checkLess.php does not validate skin styles.  This is a general issue, but is especially problematic for mediawiki.ui and mediawiki.ui.button which package all their styles this way (using 'default').

checkLess.php uses ResourceLoaderFileModule's public getAllStyleFiles method, which only uses $this->styles .
Comment 1 Gerrit Notification Bot 2014-04-01 15:20:25 UTC 
Change 122838 had a related patch set uploaded by Phuedx:
Make checkLess.php validate skin styles

https://gerrit.wikimedia.org/r/122838
Comment 2 Gerrit Notification Bot 2014-06-17 19:43:31 UTC 
Change 122838 merged by jenkins-bot:
Make ResourceLoaderFileModule#getAllStyleFiles include all skin styles

https://gerrit.wikimedia.org/r/122838
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links