Last modified: 2014-09-01 21:51:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65370, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 63370 - Use Maps and Sets in WikiConfig
Use Maps and Sets in WikiConfig
Status: NEW
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized enhancement
: ---
Assigned To: Marc Ordinas i Llopis
: easy
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-04-01 15:23 UTC by ssastry
Modified: 2014-09-01 21:51 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description ssastry 2014-04-01 15:23:08 UTC 
mediawiki.WikiConfig.js uses {} to implements maps and sets. We should go in and replace those with es6 maps and sets like in the most of the codebase.
Comment 1 Gabriel Wicke 2014-04-14 19:59:56 UTC 
In the interest of performance we should perhaps only use Map / Set where the keys are actually user-provided. The es6 shim uses objects under the hood right now, and is slower than native objects.
Comment 2 Gerrit Notification Bot 2014-08-01 12:53:48 UTC 
Change 151068 had a related patch set uploaded by Arlolra:
Use a map for the interwikiMap

https://gerrit.wikimedia.org/r/151068
Comment 3 Gerrit Notification Bot 2014-08-01 16:57:19 UTC 
Change 151068 merged by jenkins-bot:
Use a map for the interwikiMap

https://gerrit.wikimedia.org/r/151068
Comment 4 Andre Klapper 2014-09-01 12:43:21 UTC 
All patches mentioned in this report were merged or abandoned - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?
Comment 5 Arlo Breault 2014-09-01 21:51:20 UTC 
There's more work to do ... at least audit as suggested in comment 1.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links