Last modified: 2014-11-13 13:03:56 UTC
The comments to Title::newFromURL read, in part: * Example of wrong and broken code: * $title = Title::newFromURL( $wgRequest->getVal( 'title' ) ); * * Example of right code: * $title = Title::newFromText( $wgRequest->getVal( 'title' ) ); If that's accurate, then there's some code that needs fixing. Otherwise, this comment is misleading and needs correcting and/or further/clearer qualification as to when newFromURL may/should/must be used in favor of newFromText() and the related risks, if any. The core source files that have "wrong and broken code" are: ./includes/OutputPage.php ./includes/parser/CoreParserFunctions.php ./includes/specials/SpecialListfiles.php ./includes/specials/SpecialMergeHistory.php ./includes/specials/SpecialNewimages.php ./includes/specials/SpecialRecentchangeslinked.php ./includes/specials/SpecialUndelete.php ./includes/specials/SpecialWhatlinkshere.php ./includes/Wiki.php
(In reply to Daniel Norton from comment #0) > If that's accurate, then there's some code that needs fixing. Would love to have some confirmation in this ticket from some core developers.
