Last modified: 2014-04-04 20:51:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65452, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 63452 - VisualEditor: Opening a Cite>Website/Book/Newspaper/Journal while selecting an image does not open the citation dialog


Summary:	VisualEditor: Opening a Cite>Website/Book/Newspaper/Journal while selecting a...

Status:	RESOLVED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	Editing Tools (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High normal
Target Milestone:	VE-deploy-2014-04-03
Assigned To:	Trevor Parscal

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-04-02 22:52 UTC by Rummana Yasmeen
Modified:	2014-04-04 20:51 UTC (History)
CC List:	6 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Screenshot (569.89 KB, image/png) 2014-04-02 22:52 UTC, Rummana Yasmeen	Details
Add an attachment (proposed patch, testcase, etc.)

Description Rummana Yasmeen 2014-04-02 22:52:28 UTC

Created attachment 15011 [details]
Screenshot

Steps to reproduce:

1.Select an image
2.Click on Cite> Website/Book/Newspaper/Journal 

Observed Result:
It throws an error: Uncaught TypeError: Object #<VeDmMWBlockImageNode> has no method 'getInternalItem' 

and VE gets stuck at this point, as you cannot close that dialog anymore

Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser: FF 25
OS: MAC OS X 10. 8. 5 
Page:http://en.wikipedia.beta.wmflabs.org/wiki/Pageoffseterror?veaction=edit

Comment 1 Rummana Yasmeen 2014-04-02 22:57:43 UTC

It happens if you select a gallery/Math formula/template/reflist and then try to open any of the cite options

Comment 2 Trevor Parscal 2014-04-02 23:27:13 UTC

Should be resolved by I34a5a2da576247f4046da45f742bccc3cec22c5a

Specifically, the error is caused by calling getInternalItem on the node without checking if it's a ve.dm.MWReferenceNode. This patchset introduces an instanceof check.

Comment 3 Gerrit Notification Bot 2014-04-02 23:38:45 UTC

Change 123124 had a related patch set uploaded by Catrope:
Correctly insert or update citations based on template option

https://gerrit.wikimedia.org/r/123124

Comment 4 Gerrit Notification Bot 2014-04-02 23:45:07 UTC

Change 123124 merged by jenkins-bot:
Correctly insert or update citations based on template option

https://gerrit.wikimedia.org/r/123124

Comment 5 Rummana Yasmeen 2014-04-03 00:12:16 UTC

After the fix, now the Cite dialogs does not open at all after selecting any image or any other mentioned nodes.
Therefore reopening the bug and changing the title of the bug .

Comment 6 Roan Kattouw 2014-04-04 18:49:43 UTC

Works for me now, both locally and on beta labs.

Comment 7 Rummana Yasmeen 2014-04-04 20:51:55 UTC

Verified the fix on Betalabs:http://en.wikipedia.beta.wmflabs.org/wiki/Test63452?veaction=edit

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links