Last modified: 2014-04-07 17:57:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65461, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63461 - $wgMFCustomLogos['logo'] is advertised but unused
$wgMFCustomLogos['logo'] is advertised but unused
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized minor
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-03 05:18 UTC by Dan Jacobson
Modified: 2014-04-07 17:57 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Dan Jacobson 2014-04-03 05:18:27 UTC
We see

/**
 * Make the logos configurable.
 *
 * 'logo' is the principle logo for your site, 'copyright' is the copyright
 * logo to be used in the footer of your site.
 *
 * Example: array(
 * 	'logo' => 'mysite_logo.png',
 *	'copyright' => 'mysite_copyright_logo.png',
 * 	);
 */
$wgMFCustomLogos = array();

However having the user set $wgMFCustomLogos['logo'] does nothing, as
it is nowhere else in the code! P.S., principal is spelled wrong. P.S.S.
if one day it is actually used, please mention where one can expect to
see it appear.
Comment 1 Bingle 2014-04-03 05:20:10 UTC
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1898
Comment 2 Gerrit Notification Bot 2014-04-04 17:52:38 UTC
Change 123888 had a related patch set uploaded by MaxSem:
Fix outdated $wgMFCustomLogos comment

https://gerrit.wikimedia.org/r/123888
Comment 3 Gerrit Notification Bot 2014-04-07 17:57:21 UTC
Change 123888 merged by jenkins-bot:
Fix outdated $wgMFCustomLogos comment

https://gerrit.wikimedia.org/r/123888

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links