Last modified: 2014-08-07 15:29:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65469, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 63469 - Ruby linter should run after patch set submission to every repo that has Ruby code
Ruby linter should run after patch set submission to every repo that has Ruby...
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Quality Assurance (Other open bugs)
wmf-deployment
All All
: Unprioritized normal (vote)
: ---
Assigned To: Željko Filipin
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-04-03 10:12 UTC by Željko Filipin
Modified: 2014-08-07 15:29 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Željko Filipin 2014-04-03 10:12:53 UTC 
In addition to mediawiki/ruby/api[1], at least 15 other repos[2] contain Ruby code. Ruby linter should run for all those repos after every patch set submission.

1: https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/ruby/api
2: https://github.com/wikimedia/mediawiki-selenium#links
Comment 1 Gerrit Notification Bot 2014-07-29 11:12:28 UTC 
Change 150174 had a related patch set uploaded by Zfilipin:
Deleting all qa/browsertests jobs

https://gerrit.wikimedia.org/r/150174
Comment 2 Gerrit Notification Bot 2014-07-29 11:12:57 UTC 
Change 150177 had a related patch set uploaded by Zfilipin:
Running Ruby linter for ArticleFeedbackv5

https://gerrit.wikimedia.org/r/150177
Comment 3 Gerrit Notification Bot 2014-07-29 11:31:08 UTC 
Change 150189 had a related patch set uploaded by Zfilipin:
Created Ruby lint job for ArticleFeedbackv5

https://gerrit.wikimedia.org/r/150189
Comment 4 Gerrit Notification Bot 2014-07-29 17:10:45 UTC 
Change 150174 merged by jenkins-bot:
Deleting all qa/browsertests jobs

https://gerrit.wikimedia.org/r/150174
Comment 5 Željko Filipin 2014-07-30 13:03:07 UTC 
Basic ruby syntax check should now be running for all repos that have Ruby code.

The next step is to run a linter.

Dan has suggested rubocop[1]. As far as I can see it is the most popular ruby linter[2].

1: https://rubygems.org/gems/rubocop
2: https://www.ruby-toolbox.com/categories/code_metrics
Comment 6 Gerrit Notification Bot 2014-07-30 13:10:24 UTC 
Change 150189 merged by jenkins-bot:
Running Ruby linter for all repos that have Ruby code

https://gerrit.wikimedia.org/r/150189
Comment 7 Gerrit Notification Bot 2014-07-30 15:15:17 UTC 
Change 150177 merged by jenkins-bot:
Running Ruby linter for all repos that have Ruby code

https://gerrit.wikimedia.org/r/150177
Comment 8 Željko Filipin 2014-08-07 15:27:10 UTC 
Resolving as fixed. This bug has lived long enough. Will create a new bug for rubocop.
Comment 9 Željko Filipin 2014-08-07 15:29:47 UTC 
The new bug is 69245.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links