Last modified: 2014-04-17 22:57:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65503, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 63503 - VisualEditor: [Regression wmf21] 'Switch to source editing' does nothing, causes js error
VisualEditor: [Regression wmf21] 'Switch to source editing' does nothing, cau...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2014-04-10
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-04-03 22:02 UTC by Chris McMahon
Modified: 2014-04-17 22:57 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Chris McMahon 2014-04-03 22:02:26 UTC 
Reported by users and repro'd in beta labs

Log in and edit any page with VE at http://en.wikipedia.beta.wmflabs.org/

From the hamburger list select "Switch to source editing"

Nothing happens.  In the javascript console find the error 


Uncaught Error: OO.ui.Tool.onSelect not implemented in this subclass:function VeUiMWEditModeSourceTool(toolGroup,config){ve.ui.MWEditModeTool.call(this,toolGroup,config);}
Comment 1 Chris McMahon 2014-04-03 22:16:47 UTC 
also repro'd on test2wiki
Comment 2 Gerrit Notification Bot 2014-04-03 23:58:44 UTC 
Change 123806 had a related patch set uploaded by Alex Monk:
Revert edit mode tool's onSelect method

https://gerrit.wikimedia.org/r/123806
Comment 3 Gerrit Notification Bot 2014-04-04 00:04:31 UTC 
Change 123806 had a related patch set uploaded by Alex Monk:
Revert edit mode tool's onSelect method

https://gerrit.wikimedia.org/r/123806
Comment 4 Gerrit Notification Bot 2014-04-04 00:07:30 UTC 
Change 123806 merged by jenkins-bot:
Revert edit mode tool's onSelect method

https://gerrit.wikimedia.org/r/123806
Comment 5 Gerrit Notification Bot 2014-04-04 02:10:58 UTC 
Change 123825 had a related patch set uploaded by Jforrester:
Revert edit mode tool's onSelect method

https://gerrit.wikimedia.org/r/123825
Comment 6 Rummana Yasmeen 2014-04-04 17:54:13 UTC 
Verified the fix on Betalabs: http://en.wikipedia.beta.wmflabs.org/wiki/Regression3rdaprilchrome
Comment 7 Gerrit Notification Bot 2014-04-07 23:30:45 UTC 
Change 123825 merged by jenkins-bot:
Revert edit mode tool's onSelect method

https://gerrit.wikimedia.org/r/123825
Comment 8 Rummana Yasmeen 2014-04-08 23:22:05 UTC 
Verified the fix in mw.org
Comment 9 Rummana Yasmeen 2014-04-17 22:57:44 UTC 
Verified the fix in production:
https://en.wikipedia.org/wiki/User:RYasmeen_(WMF)/sandbox
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links