Last modified: 2014-05-11 13:16:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65508, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63508 - Hovercards: cards should inherit default Vector typography
Hovercards: cards should inherit default Vector typography
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Popups (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Vibha Bamba
:
: 65045 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-04 02:19 UTC by Dan Garry
Modified: 2014-05-11 13:16 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
screenshot - smaller text (262.15 KB, image/png)
2014-04-21 16:40 UTC, Quiddity
Details
screenshot - larger text (266.07 KB, image/png)
2014-04-21 16:41 UTC, Quiddity
Details
screenshot - last edited div-size (268.39 KB, image/png)
2014-04-21 16:54 UTC, Quiddity
Details
screenshot - even larger text (265.63 KB, image/png)
2014-04-30 22:36 UTC, Quiddity
Details

Description Dan Garry 2014-04-04 02:19:34 UTC
The typography refresh changed the font size on Wikimedia wikis, but Hovercards has not been affected by the typeface changes.

Hovercards should respect the typeface of the wiki it's running on.
Comment 1 Prateek Saxena 2014-04-05 13:11:42 UTC
If I remember correctly Vibha and I took this decision consciously according to the size of the hovercard. It initially *was* picking up the typography of the wiki but that wasn't working out.
Comment 2 Vibha Bamba 2014-04-11 00:56:37 UTC
Prateek and I have discussed this. Respecting the typography will significantly increase the size of the layout. Will review with Jared before resolution.
Comment 3 Dan Garry 2014-04-11 21:07:19 UTC
(In reply to Vibha Bamba from comment #2)
> Prateek and I have discussed this. Respecting the typography will
> significantly increase the size of the layout. Will review with Jared before
> resolution.

I actually filed this bug on the advice of Jared (an email he sent on 3rd April 2014 at 19:00).

Ultimately, I feel this is primarily a design decision so it's up to you how to proceed. I'll support your decision, whatever it is.
Comment 4 Vibha Bamba 2014-04-14 23:58:16 UTC
Prateek, I chatted with Jared with this. Here is an idea. What if we set up an instance on labs with a few articles and a switch. The Switch works as follows -
1. Replicate a version of hovercards which respects the typography of the page. 
2. Create a second instance that uses a 125% increment in the type size. 
I know this sounds strange, because we will see much less text if the size of the popup stays at what it is right now. The rationale is that users need to be able to read the popup quickly. So showing less text which can be more efficiently read is worth the tradeoff.
Comment 5 Gerrit Notification Bot 2014-04-17 13:04:14 UTC
Change 126970 had a related patch set uploaded by Prtksxna:
DONT MERGE/REVIEW - Pref for testing on chicken

https://gerrit.wikimedia.org/r/126970
Comment 6 Prateek Saxena 2014-04-17 13:04:56 UTC
The patch is only for testing.
Comment 7 Jared Zimmerman (WMF) 2014-04-17 18:37:46 UTC
my recommendation is that the type be at minimum the same size as the body text, and ideally larger. This would mean less text, not bigger hovercards.
Comment 8 Vibha Bamba 2014-04-17 18:44:08 UTC
Agree, that is the idea. Size of popups is not going to increase.
Comment 9 Gerrit Notification Bot 2014-04-20 16:18:44 UTC
Change 126970 abandoned by Prtksxna:
DONT MERGE/REVIEW - Pref for testing on chicken

Reason:
It was alright to do this with common.css

https://gerrit.wikimedia.org/r/126970
Comment 10 Prateek Saxena 2014-04-21 10:28:56 UTC
To see the current type size go to
http://chicken.wmflabs.org/wiki/Main_Page and login using the
following credentials-

User: normal
Password: normalnormal

To see the larger type go to the same page and login with the
following credentials-

User: test
Password: testtest

You are seeing the larger type if you see the logo on the top left spinning.
Comment 11 Pau Giner 2014-04-21 16:16:45 UTC
The larger type looks good to me. More welcoming to read while still providing enough text to provide context.
Comment 12 Quiddity 2014-04-21 16:40:49 UTC
Created attachment 15144 [details]
screenshot - smaller text
Comment 13 Quiddity 2014-04-21 16:41:15 UTC
Created attachment 15145 [details]
screenshot - larger text
Comment 14 Quiddity 2014-04-21 16:54:22 UTC
Created attachment 15146 [details]
screenshot - last edited div-size

I agree the larger font for the extract is good.  

However, could the "last edited [time]" be reduced in font-size, and drastically reduced in div-height? It's currently taking up ~55px out of ~400px.
Comment 15 Vibha Bamba 2014-04-21 18:00:48 UTC
Can we try 0.5em larger? Right now the type size looks practically the same as the background article text. If its different, then its better for it to have a good size contrast.
Comment 16 Prateek Saxena 2014-04-30 15:03:27 UTC
Do we need any other tests before we make the decision?
Comment 17 Quiddity 2014-04-30 22:36:50 UTC
Created attachment 15258 [details]
screenshot - even larger text

Here's the 0.5em larger font, screenshot attached.

The "last edited [time]" div really really needs to be reduced.
Comment 18 Prateek Saxena 2014-05-09 19:55:07 UTC
Should I mark this as duplicate of 65045 and close this?
Comment 19 Prateek Saxena 2014-05-10 06:11:07 UTC
*** Bug 65045 has been marked as a duplicate of this bug. ***
Comment 20 Prateek Saxena 2014-05-10 06:12:14 UTC
(Quoting Vibha's comment from bug 65045)

Need to make the type size bigger so a reader can scan it quickly.
We have been testing a larger type size and it helps with quick reading. The caveat is that a user sees less text. 

.mwe-popups{
font-size: 15px;
line-height:24px;
}
 
.mwe-popups-extract {
max-height: 103px !important;
}
 
.mwe-popups-is-tall .mwe-popups-extract {
max-height: 100px !important;
}
Comment 21 Gerrit Notification Bot 2014-05-10 06:13:15 UTC
Change 132492 had a related patch set uploaded by Prtksxna:
Increase font size

https://gerrit.wikimedia.org/r/132492
Comment 22 Gerrit Notification Bot 2014-05-10 13:49:23 UTC
Change 132492 merged by jenkins-bot:
Increase font size

https://gerrit.wikimedia.org/r/132492

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links