Last modified: 2014-07-24 22:12:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65546, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63546 - Message keys visible instead of UI strings
Message keys visible instead of UI strings
Status: RESOLVED FIXED
Product: Wikipedia App
Classification: Unclassified
Localization/Translation/Language (Other open bugs)
iOS (alpha)
All All
: Unprioritized normal
: ---
Assigned To: Brion Vibber
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-04 19:55 UTC by Siebrand Mazeland
Modified: 2014-07-24 22:12 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot 1 (67.83 KB, image/jpeg)
2014-04-04 19:55 UTC, Siebrand Mazeland
Details
Screenshot 2 (99.19 KB, image/jpeg)
2014-04-04 19:56 UTC, Siebrand Mazeland
Details

Description Siebrand Mazeland 2014-04-04 19:55:44 UTC
Created attachment 15019 [details]
Screenshot 1

Observed in 4.0#10 (installed through Testflight).

Message keys are visible in the attached screenshots.
Comment 1 Siebrand Mazeland 2014-04-04 19:56:10 UTC
Created attachment 15020 [details]
Screenshot 2
Comment 2 Brion Vibber 2014-04-07 17:26:54 UTC
Ouch, looks like a bug in the fallback order.
Comment 3 Brion Vibber 2014-04-10 20:22:17 UTC
Ok, so doing some research it looks like NSLocalizedString doesn't handle fallback on individual strings the way we expected; we'll have to write a custom function that handles it, such as this example: http://stackoverflow.com/questions/3263859/localizing-strings-in-ios-default-fallback-language/8784451#8784451
Comment 4 Brion Vibber 2014-04-10 20:52:55 UTC
Provisional fix in https://gerrit.wikimedia.org/r/#/c/125326/ -- adds MWLocalizedString macro to use in place of NSLocalizedString, which falls back to English instead of to the raw key value if there's a missing localization.

(Tested with es which is currently missing that menu key from the sample, which got filled in in nl)

Will apply on the rest after next big merge from Monte, as some renamed directories will make the auto-merge not pretty probably. :D
Comment 5 Brion Vibber 2014-07-24 22:12:25 UTC
This got done some time ago.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links